Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

autofill pulldown should consider downloadBar height #9020

Closed
luixxiul opened this issue May 24, 2017 · 2 comments · Fixed by #9027
Closed

autofill pulldown should consider downloadBar height #9020

luixxiul opened this issue May 24, 2017 · 2 comments · Fixed by #9027
Assignees
@darkdh
Labels
bug feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: autofill pulldown should consider downloadBar height.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Tested on Debian

  • Brave Version (revision SHA): 0.15.307 / this cannot be reproduced on 0.15.2

  • Steps to reproduce:

    1. Open about:autofill
    2. Create an entry
    3. Open www.roboform.com/filling-test-all-fields
    4. Download that page
    5. Trigger the autofill pulldown

  • Actual result:
    clipboard01

  • Expected result:
    After dismissing the download bar:
    clipboard01

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul added this to the 0.15.300 milestone May 24, 2017
@bsclifton
Copy link
Member

@darkdh can you help with this?

@darkdh
Copy link
Member

darkdh commented May 24, 2017

sure

darkdh added a commit that referenced this issue May 24, 2017
@darkdh
Remove downloadsBarOffset for new coordinate calculation
4cd3515 
fix #9020

Auditors: @bsclifton, @bbondy

Test Plan:
1. Open about:autofill
2. Create an entry
3. Open www.roboform.com/filling-test-all-fields
4. Download that page
5. Trigger the autofill pulldown with different UI scale
@darkdh darkdh mentioned this issue May 24, 2017
Merged
7 tasks
bsclifton pushed a commit that referenced this issue May 24, 2017
@darkdh @bsclifton
Remove downloadsBarOffset for new coordinate calculation
16f3ab1 
fix #9020

Auditors: @bsclifton, @bbondy

Test Plan:
1. Open about:autofill
2. Create an entry
3. Open www.roboform.com/filling-test-all-fields
4. Download that page
5. Trigger the autofill pulldown with different UI scale
This was referenced May 25, 2017
Closed
Closed
Closed
@srirambv srirambv mentioned this issue May 29, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Remove downloadsBarOffset for new coordinate calculation brave/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv