Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor safebrowsing.js with Aphrodite #9025

Closed
luixxiul opened this issue May 24, 2017 · 7 comments · Fixed by #13592
Closed

Refactor safebrowsing.js with Aphrodite #9025

luixxiul opened this issue May 24, 2017 · 7 comments · Fixed by #13592
Assignees
@jasonrsadler
Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 24, 2017 •
edited by bsclifton
Loading

Describe the issue you encountered: Refactor safebrowsing.js with Aphrodite.

Test plan

1. Open Brave and go to about:safebrowsing
2. Ensure styling of safe browsing page remains sane with previous versions
@luixxiul luixxiul added this to the 0.16.200 milestone May 24, 2017
@luixxiul luixxiul self-assigned this May 24, 2017
@luixxiul luixxiul mentioned this issue May 24, 2017
Merged
7 tasks
cezaraugusto pushed a commit that referenced this issue May 30, 2017
@cezaraugusto
Fix margin around the button on about:safebrowsing
ce6613c 
Closes #8945
Addresses #9025

Auditors:

Test Plan:
1. Open downloadme.org
2. Click "Advanced" button
3. Click "Hide advanced" button
4. Make sure the button does not move
@cezaraugusto cezaraugusto modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
@alexwykoff alexwykoff removed this from the 0.19.x (Beta Channel) milestone Jul 18, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@luixxiul luixxiul removed their assignment Feb 13, 2018
cezaraugusto added a commit that referenced this issue May 10, 2018
@cezaraugusto
Merge pull request #13592 from jasonrsadler/safe-browsing-aphrodite-r…
e278ba6 
…efactor

Finished Aphrodite restyle of safebrowsing.js. Fixes issue #9025
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.23.x (Developer Channel) May 10, 2018
@NejcZdovc
Copy link
Contributor

closed with #13592

@bsclifton
Copy link
Member

@jasonrsadler can you please add some testing steps for this? Or if you and @cezaraugusto agree it doesn't need manual testing, let's mark as no-qa-needed

bsclifton pushed a commit that referenced this issue May 10, 2018
@cezaraugusto @bsclifton
Merge pull request #13592 from jasonrsadler/safe-browsing-aphrodite-r…
688f8f9 
…efactor

Finished Aphrodite restyle of safebrowsing.js. Fixes issue #9025
@jasonrsadler
Copy link
Contributor

@bsclifton I'll put some placeholder steps until I confer with @cezaraugusto on what the appropriate testing steps should be.

@cezaraugusto
Copy link
Contributor

Labeling as no-qa-needed as no functionality was added and no design was changed.

@jasonrsadler jasonrsadler mentioned this issue May 10, 2018
Merged
10 tasks
This was referenced Jun 19, 2018
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
This was referenced Jun 21, 2018
Closed
Closed
Closed
Closed
Closed
@kjozwiak
Copy link
Member

@bsclifton should this be removed due to removing the safe browsing work from muon for 0.23.x as it caused issues? Seems to be a simple refactor but want to make sure just incase.

@bsclifton
Copy link
Member

@kjozwiak we're good to keep this in 😄 Safe browsing should still be present in Brave

This was referenced Jun 25, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jun 25, 2018 •
edited by kjozwiak
Loading

Verified with macOS 10.12.6 using

  • 0.23.17 bc754eb
  • Muon 7.1.2
  • libchromiumcontent 67.0.3396.87

Verified on Windows 10 x64 using

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 18.04 x64 using the following build:

  • 0.23.17 bc754eb
  • muon: 7.1.2
  • libchromiumcontent: 67.0.3396.87

about:safebrowsing page under 0.23.17 bc754eb:

screen shot 2018-06-25 at 2 05 04 pm

about:safebrowsing page under 0.22.810 8f30eeb:

screen shot 2018-06-25 at 2 07 40 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonrsadler jasonrsadler

Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Finished Aphrodite restyle of safebrowsing.js. Fixes issue #9025
9 participants
@alexwykoff @kjozwiak @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @jasonrsadler @LaurenWags