Make Autofill country field into a dropdown list #9053

srirambv · 2017-05-25T17:37:54Z

Test plan

#10821 (comment)

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Make country into a dropdown list
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
Brave 0.15.308
rev fc4b892
Muon 3.0.200
Screenshot if needed:

Future enhancement: make state field also drop down. Ref here

Any related issues: Credit Card autofill doesn't fill expiry date. #3727

The text was updated successfully, but these errors were encountered:

dfperry5 · 2017-07-31T02:47:14Z

Hi guys,

Anyone taken a stab at this yet? Im just starting into OSS and would like to give it a shot.

Thanks!

bsclifton · 2017-07-31T06:56:36Z

@dfperry5 nope, it's all yours! 😄

Let me know if you have any questions / need help / want someone to try out your changes 😄

dfperry5 · 2017-07-31T16:41:26Z

@bsclifton Awesome :) I'll get right on it - I'll be working in the airports today so no promises on anything today, but ill try to have something to share soon!

Thanks!

bsclifton · 2017-08-01T01:39:55Z

@dfperry5 how's it going? Just wanted to check in 😄 Hope all is well

dfperry5 · 2017-08-01T04:52:35Z

@bsclifton It's going good :) Just a lot of reading through the code, etc :P Been a lot of just sitting in airports today. Also, just trying to make sure i have the process correct.

It's cool if i just cut my own branch off master, and just start committing to that? I can post the branch name here so everyone can check it out?

Thanks!

dfperry5 · 2017-08-01T05:11:45Z

So just to further clarify this issue --

The issue is when the user is enabling auto fill and filling out their address information. At that point, the input for country / region should be a dropdown?

bsclifton · 2017-08-01T05:50:07Z

@dfperry5 when you visit about:autofill, it currently has text fields for all values.

We need to update our form to have a dropdown instead, offering a common selection of countries. I'd recommend getting it working with a few countries first to make sure you're comfortable with the solution.

Once you're ready to add them all, you can find a list here 😄
http://www.listofcountriesoftheworld.com

bsclifton · 2017-08-01T05:52:27Z

for a demo of how to do a dropdown using our code, navigate over to about:styles. You'll see a few live examples and the React code used to generate them.

The code for the form in the above screenshot can be found here:
https://github.com/brave/browser-laptop/blob/117d8e39e43962946532e9c154acd9b62fa00e8b/js/about/autofill.js

dfperry5 · 2017-08-01T05:54:45Z

@bsclifton awesome! I'll comment back here once I have something working (most likely tomorrow evening est time)!

Thanks for all the help!

bsclifton · 2017-08-01T06:13:19Z

@dfperry5 perfect! You can fork Brave and start committing locally. Once you feel confident, you can submit a pull request (if you need help working with forks or git, let me know and we'll work it out 😄 )

darkdh · 2017-08-01T18:16:41Z

@dfperry5, please set The ISO 3166 2-letter country code for the value. you can find the code here
https://www.iso.org/obp/ui/#search/code/

I remember @aekeus has the country list for add funds. Maybe he can give some input.

dfperry5 · 2017-08-02T00:11:05Z

@bsclifton I think i have it working on my local. I forked the repo here.

I was trying to commit but, but I'm failing the pre-commit hook:
"Error generating docs for file windowActions.js SyntaxError: Unexpected end of JSON input"

Any ideas?

bsclifton · 2017-08-02T05:43:38Z

@dfperry5 ah that error... Yeah, we need to fix that (captured here)

In the meantime, you can edit package.json and just replace the part under "scripts":
"docs": "jsdox js/actions/appActions.js js/actions/windowActions.js --output docs",

with something like:
"docs": "echo docs",

That should let you add your files and commit 😄 I'd love to check it out once you have the code pushed. Thanks for digging in!

This is the first pass at creating a dropdown for the country list in the about:autofill panel Fix brave#9053

dfperry5 · 2017-08-02T11:16:47Z

@bsclifton I'm not sure its beautiful, but it seems to be working :)

See here.

Let me know whatcha think! Any suggestions are welcome.

@darkdh I used the 2-Letter country codes as well -- feel free to check it out :)

Thanks for all the help!

Updated country name from Taiwain, Province of China to Taiwain Fix brave#9053

…or country localization modified: app/locale.js

…ame not country code

…tofill.js not the autofillAddressPanel component modified: app/renderer/components/autofill/autofillAddressPanel.js modified: js/about/autofill.js modified: js/about/autofill.js

Creating a dropdown for the country list in the about:autofill panel Fix brave#9053

…list to just be countryCodes, and updating asssoicated references

Creating a dropdown for the country list in the about:autofill panel Fix brave#9053

…tries is a blank modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js

luixxiul · 2017-09-06T11:58:17Z

I'm resetting the milestone to 0.21.x (which is still open for landing) as 0.22.x milestone was added at first by myself to #10300 without a special reason and #10821 does not conflict with other stuff which is planned for 0.22.x. If it does by any chance, please revert the milestone.

Issue #9053: Making country field in autofill a dropdown list instead of text input box.

@diracdeltas

When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages TODO: Update localization for all languages for this state Fixes brave#7747 Update test Return 0% when download totalBytes is 0 or undefined Fix brave#10264 Updated code to handle falsey inputs + added more unit tests :) Auditors: @diracdeltas Test Plan: `npm run unittest -- --grep="downloadUtil"` Move properties inside main.less to window.less Closes brave#10860 Auditors: Test Plan: 1. npm run watch 2. npm start 3. Make sure the browser starts 4. Open the devtool and make sure the two properties are applied Converted Country Textbox to Select Dropdown Creating a dropdown for the country list in the about:autofill panel Fix brave#9053 Small cleanup for autofill country list per discussion in PR Auditors: @dfperry5 Fix two issues - handle when locale is called with null/undefined/falsey value (before would fail on toLowerCase()) - handle situation where activeTab is not set and developer tools are opened (will be fixed soon by @bbondy) Auditors: @bbondy, @dfperry5 Issue brave#9053 - Updating so that first option on dropdown for countries is a blank modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js Add 'CommonFormFullWidthDropdown' to commonForm.js Auditors: @cezaraugusto Test Plan: 1. Open about:autofill 2. Click 'Add Address' Update autofill webdriver tests to use Country as a dropdown value instead of a text field Auditors: @dfperry5, @darkdh, @luixxiul Test Plan: `npm run test -- --grep="Autofill" Style Edits Auditors: Test Plan:

srirambv added bug/good-first-bug feature/autofill suggestion labels May 25, 2017

srirambv assigned darkdh May 25, 2017

darkdh removed their assignment May 25, 2017

bsclifton self-assigned this Jul 31, 2017

bsclifton closed this as completed Aug 2, 2017

bsclifton reopened this Aug 2, 2017

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 2, 2017

Converted Country Textbox to Select Dropdown

75fe9b5

This is the first pass at creating a dropdown for the country list in the about:autofill panel Fix brave#9053

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 3, 2017

Updating the country name of Taiwan

f218468

Updated country name from Taiwain, Province of China to Taiwain Fix brave#9053

dfperry5 mentioned this issue Aug 14, 2017

Issue #9053: Making country field in autofill a dropdown list instead of text input box. #10300

Closed

8 tasks

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 17, 2017

Issue brave#9053 - Updating l10n for country code

e9da729

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 17, 2017

Issue brave#9053 - Updating app/locale to use countries.properties f…

a120276

…or country localization modified: app/locale.js

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 17, 2017

Issue brave#9053 - Updating autofill address panel to show country n…

1c8810c

…ame not country code

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017

Issue brave#9053 Adding in localizaiton for country autofill

06748ec

bsclifton pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 21, 2017

Converted Country Textbox to Select Dropdown

8ab1959

Creating a dropdown for the country list in the about:autofill panel Fix brave#9053

bsclifton added this to the 0.22.x milestone Aug 21, 2017

dfperry5 added a commit to dfperry5/browser-laptop that referenced this issue Aug 21, 2017

Fix brave#9053: Code cleanup - removing comments, changing countries …

cd9c321

…list to just be countryCodes, and updating asssoicated references

bsclifton pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 21, 2017

Converted Country Textbox to Select Dropdown

7e01dc7

Creating a dropdown for the country list in the about:autofill panel Fix brave#9053

bsclifton pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 22, 2017

Converted Country Textbox to Select Dropdown

471e996

Creating a dropdown for the country list in the about:autofill panel Fix brave#9053

luixxiul mentioned this issue Sep 6, 2017

Issue #9053: Making country field in autofill a dropdown list instead of text input box. #10821

Merged

8 tasks

luixxiul added needs-triage QA/test-plan-specified and removed needs-triage labels Sep 6, 2017

luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.22.x Sep 6, 2017

bsclifton closed this as completed in #10821 Sep 10, 2017

bsclifton added a commit that referenced this issue Sep 10, 2017

Merge pull request #10821 from luixxiul/countryfield

79df4ed

Issue #9053: Making country field in autofill a dropdown list instead of text input box.

luixxiul added the release-notes/include label Sep 10, 2017

bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017

luixxiul added the QA/checked-Linux label Nov 6, 2017

This was referenced Dec 20, 2017

Per-release specialty test run on OS X for 0.20.x (Beta Channel) #12337

Closed

Per-release specialty test run on Windows x64 for 0.20.x (Beta Channel) #12338

Closed

srirambv added the QA/checked-Win64 label Dec 21, 2017

LaurenWags added the QA/checked-macOS label Dec 22, 2017

kjozwiak mentioned this issue Jan 31, 2018

Release notes for 0.20.29 #12949

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Autofill country field into a dropdown list #9053

Make Autofill country field into a dropdown list #9053

srirambv commented May 25, 2017 •

edited by luixxiul

Loading

dfperry5 commented Jul 31, 2017

bsclifton commented Jul 31, 2017 •

edited

Loading

dfperry5 commented Jul 31, 2017

bsclifton commented Aug 1, 2017

dfperry5 commented Aug 1, 2017

dfperry5 commented Aug 1, 2017

bsclifton commented Aug 1, 2017 •

edited

Loading

bsclifton commented Aug 1, 2017 •

edited

Loading

dfperry5 commented Aug 1, 2017

bsclifton commented Aug 1, 2017

darkdh commented Aug 1, 2017

dfperry5 commented Aug 2, 2017

bsclifton commented Aug 2, 2017

dfperry5 commented Aug 2, 2017 •

edited

Loading

luixxiul commented Sep 6, 2017 •

edited

Loading

Make Autofill country field into a dropdown list #9053

Make Autofill country field into a dropdown list #9053

Comments

srirambv commented May 25, 2017 • edited by luixxiul Loading

Test plan

dfperry5 commented Jul 31, 2017

bsclifton commented Jul 31, 2017 • edited Loading

dfperry5 commented Jul 31, 2017

bsclifton commented Aug 1, 2017

dfperry5 commented Aug 1, 2017

dfperry5 commented Aug 1, 2017

bsclifton commented Aug 1, 2017 • edited Loading

bsclifton commented Aug 1, 2017 • edited Loading

dfperry5 commented Aug 1, 2017

bsclifton commented Aug 1, 2017

darkdh commented Aug 1, 2017

dfperry5 commented Aug 2, 2017

bsclifton commented Aug 2, 2017

dfperry5 commented Aug 2, 2017 • edited Loading

luixxiul commented Sep 6, 2017 • edited Loading

srirambv commented May 25, 2017 •

edited by luixxiul

Loading

bsclifton commented Jul 31, 2017 •

edited

Loading

bsclifton commented Aug 1, 2017 •

edited

Loading

bsclifton commented Aug 1, 2017 •

edited

Loading

dfperry5 commented Aug 2, 2017 •

edited

Loading

luixxiul commented Sep 6, 2017 •

edited

Loading