Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

in bookmark manager, can't scroll down to the latest bookmark under bookmark's list #9055

Closed
cezaraugusto opened this issue May 25, 2017 · 0 comments
Closed

in bookmark manager, can't scroll down to the latest bookmark under bookmark's list #9055

cezaraugusto opened this issue May 25, 2017 · 0 comments
Assignees
@cezaraugusto
Labels
feature/about-pages feature/bookmarks QA/test-plan-specified release-notes/include
Milestone
0.16.9

Comments

@cezaraugusto
Copy link
Contributor

STR:

  1. Import a lot of bookmarks, go to about:bookmarks
  2. On the right-hand side of the panel, with enough bookmarks to have a scroll, try scrolling to the latest bookmark.
  3. Panel is set to 100vh, scroll is invisible and you can't click the latest one

The issue is caused because, unlike folderView, we aren't taking into account the page header's size.
@cezaraugusto cezaraugusto added this to the 0.16.100 milestone May 25, 2017
@cezaraugusto cezaraugusto self-assigned this May 25, 2017
@cezaraugusto cezaraugusto changed the title can't scroll down to the latest bookmark when organizeView has scroll in bookmark manager, can't scroll down to the latest bookmark under bookmark's list Jun 9, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.16.7, 0.17.x (Frozen, only critical adds from here) Jun 9, 2017
alexwykoff pushed a commit that referenced this issue Jun 9, 2017
@cezaraugusto @alexwykoff
[about:bm] allow latest bookmark to be visible when scroll is on
7ea7def 
Auditors: @luixxiul
Fix: #9055
Test Plan:
with enough bookmarks to make page scrollable,
latest bookmark inside organizeView under about:bookmarks
should be visible and clickable.
@cezaraugusto cezaraugusto mentioned this issue Jun 9, 2017
Closed
@eljuno eljuno mentioned this issue Jun 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/about-pages feature/bookmarks QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.16.9
Development

No branches or pull requests
2 participants
@luixxiul @cezaraugusto