Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark title is not selected automatically #9091

Closed
NejcZdovc opened this issue May 27, 2017 · 1 comment
Closed

Bookmark title is not selected automatically #9091

NejcZdovc opened this issue May 27, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
automated-tests bug QA/no-qa-needed regression release-notes/include
Milestone
0.17.13 (Release ...

Comments

@NejcZdovc
Copy link
Contributor

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Bookmark title is not selected automatically. This bug was introduces in this PR Check input value before set it #9031.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    1da2c27

  • Steps to reproduce:

    1. Go to some page
    2. Click bookmark star

  • Actual result:
    image

  • Expected result:
    image

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes
@NejcZdovc NejcZdovc self-assigned this May 27, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 27, 2017
@NejcZdovc
Fixes bookmark title selection
cdecc9b 
Resolves brave#9091

Auditors: @bsclifton @darkdh

Test Plan:
- covered with tests
@NejcZdovc NejcZdovc mentioned this issue May 27, 2017
Merged
7 tasks
NejcZdovc added a commit that referenced this issue May 27, 2017
@NejcZdovc
Merge pull request #9092 from NejcZdovc/hotfix/#9091-bookmark
d65a6ba 
Fixes bookmark title selection
@NejcZdovc NejcZdovc added this to the 0.16.100 (Frozen, only critical adds from here) milestone May 27, 2017
@bsclifton
Copy link
Member

bsclifton commented May 30, 2017 •
edited
Loading

Labelled with automated-tests and QA/no-qa-needed since this should be covered by tests (per comment in #9092)

This was referenced Jun 19, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests bug QA/no-qa-needed regression release-notes/include
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

No branches or pull requests
3 participants
@luixxiul @bsclifton @NejcZdovc