WebView Not Visible in Popup Window

[jonathansampson]

Test plan

1. Navigate to https://www.dropbox.com/login
2. Click 'Sign in with Google'
3. Window will pop up; it should not be blank

Description

Workround: Open a new tab then switch back to existing tab

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When triggering a popup window, I find that the <webview/> is not visible (nor does it load).

Cause:
The issue here is a missing .isActive class on the div.frameWrapper element. Having no isActive or isPreview class causes the webview to be visibility: hidden.

Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10

Brave Version (revision SHA):
6b5e4e2

Steps to reproduce:

1. Navigate to https://www.dropbox.com/login
2. Click 'Sign in with Google'

Actual result:
Tab contents in popup are solid white.

Expected result:
Tab contents in popup contain login form.

Will the steps above reproduce in a fresh profile? If not what other info can be added?
TBD

Is this an issue in the currently released version?
Yes

Can this issue be consistently reproduced?
Yes

[luixxiul]

By disabling FP and reloading I got the log-in pop up window, which is working.

[jonathansampson]

@luixxiul I don't have FP enabled.

[bbondy]

maybe intermittent and not related to FP?
Are you both using Windows?

[jonathansampson]

@bbondy Not intermittent for me; repros consistently, across multiple domains (including all OAUTH login forms that I've tested). I've only tested on Windows.

[bbondy]

I can reproduce as well on both Linux and WIndows. I assume mac is the same but I don't have access to a Mac for a week.

[bridiver]

I can't repro on mac in master

[bridiver]

@jonathansampson/@bbondy can you reproduce on master?

[bridiver]

I can repro on windows so it looks like it must be windows/linux only

[bbondy]

reproduces on master

[bridiver]

this isn't 100% reproducible even on windows. It happens intermittently and I think it's the same race condition we are seeing in other places with the app state. I have a workaround for now

[NejcZdovc]

I can reproduce this 100% on macOS. Sadly it's on a bank site, so I can't share URL and STR, because you need to login to trigger it

[bsclifton]

@NejcZdovc same

[NejcZdovc]

Just test it out and b5e55d3 fix this problem for me

[bridiver]

if you can reproduce 100% of the time you need a laptop upgrade ;) I couldn't even repro 100% of the time on my windows VM

[NejcZdovc]

😄 I can only reproduce it on my bank site

[jonathansampson]

@bridiver I can/could reproduce 100% of the time on my Surface Book i7 :)

[bsclifton]

Marking as closed since the work-around has been committed 😄