Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Spell check not working with C59 #9102

Closed
bbondy opened this issue May 28, 2017 · 1 comment · Fixed by brave/muon#203
Closed

Spell check not working with C59 #9102

bbondy opened this issue May 28, 2017 · 1 comment · Fixed by brave/muon#203
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.16.x (Frozen, o...

Comments

@bbondy
Copy link
Member

bbondy commented May 28, 2017 •
edited
Loading

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Spell check isn't working with the C59 upgrade

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on Windows, but probably all.

  • Brave Version (revision SHA):
    be76cd3

  • Steps to reproduce:

    1. Navigate to https://github.com/fdafdasfasdfdsafasdfds
    2. Type the following text in the textbox: Hallo werld

  • Actual result:
    No underlines

  • Expected result:
    Red underlines

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes
@bbondy bbondy added this to the 0.16.0 milestone May 28, 2017
@luixxiul luixxiul added the cr59 label May 29, 2017
@luixxiul luixxiul mentioned this issue May 29, 2017
Closed
This was referenced May 29, 2017
Closed
Closed
@darkdh darkdh self-assigned this May 30, 2017
darkdh added a commit to brave/muon that referenced this issue May 31, 2017
@darkdh
Call WebView:SetTextCheckClient in initialization
83a66e5 
see chromium commits:
https://chromium.googlesource.com/chromium/src.git/+/62dc793dc640ae5fd16d571a0c9199fe0fb740d0
->
https://chromium.googlesource.com/chromium/src.git/+/81bfb1741ab51947f5fc7c741eadd92779fe13b2
->
https://chromium.googlesource.com/chromium/src.git/+/1c4d759e44259650dfb2c426a7f997d2d0bc73dc
->
https://chromium.googlesource.com/chromium/src.git/+/0c92b1cfa21b855c0e8c19f5550ae5209a325936

fix brave/browser-laptop#9102

Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue May 31, 2017
Merged
bridiver pushed a commit to brave/muon that referenced this issue Jun 2, 2017
@darkdh @bridiver
Call WebView:SetTextCheckClient in initialization
4948423 
see chromium commits:
https://chromium.googlesource.com/chromium/src.git/+/62dc793dc640ae5fd16d571a0c9199fe0fb740d0
->
https://chromium.googlesource.com/chromium/src.git/+/81bfb1741ab51947f5fc7c741eadd92779fe13b2
->
https://chromium.googlesource.com/chromium/src.git/+/1c4d759e44259650dfb2c426a7f997d2d0bc73dc
->
https://chromium.googlesource.com/chromium/src.git/+/0c92b1cfa21b855c0e8c19f5550ae5209a325936

fix brave/browser-laptop#9102

Auditors: @bridiver, @bbondy
This was referenced Jun 7, 2017
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Jun 7, 2017
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 7, 2017

Spell check works but underline is retained. #9324 logged for the same

@alexwykoff alexwykoff mentioned this issue Jun 8, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.16.x (Frozen, only critical adds fr...
Development

Successfully merging a pull request may close this issue.

Call WebView:SetTextCheckClient in initialization brave/muon
6 participants
@bbondy @alexwykoff @luixxiul @darkdh @srirambv @LaurenWags