Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension tabs not auto closing when finished #9132

Closed
mouse-man opened this issue May 29, 2017 · 2 comments
Closed

Extension tabs not auto closing when finished #9132

mouse-man opened this issue May 29, 2017 · 2 comments

Comments

@mouse-man
Copy link

mouse-man commented May 29, 2017

Test plan

  1. Open browser
  2. Enable LastPass with 2FA code enabled
  3. Enter code and press button
  4. Test that authentication succeeds
  5. Test that the tab is closed

Describe the issue you encountered: Tested with both LastPass and Pocket.

Log in via pocket, tab doesn't close once authenticated.
2FA in LastPass, tab doesn't close once button clicked to submit code.

Both show they actually authenticated the extension as I can then interact with the extension (i.e. add articles to Pocket or log in via LastPass filled credentials.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Win8.1 Pro and Win10 Pro Fast ring.

  • Brave Version (revision SHA): 0.15.310

  • Steps to reproduce:

    1. Open browser, LastPass asks for 2FA code
    2. Enter code and press button
    3. Extension authenticates, however tab is not closed
  • Actual result: Tab not closed

  • Expected result: Tab closed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added? Yes

  • Is this an issue in the currently released version?
    Yes, only occurred after latest update on both machines.

  • Can this issue be consistently reproduced? Yes

#9113

@jonathansampson
Copy link
Collaborator

Tracking at #4687

@luixxiul luixxiul added this to the 0.18.x (Beta Channel) milestone Jul 22, 2017
@luixxiul
Copy link
Contributor

adding the labels as #4687 has been labelled with no-qa-needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants