Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension API: chrome.tabs.remove #4687

Closed
jonathansampson opened this issue Oct 11, 2016 · 4 comments
Closed

Extension API: chrome.tabs.remove #4687

jonathansampson opened this issue Oct 11, 2016 · 4 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 11, 2016

https://developer.chrome.com/extensions/tabs#method-remove

Blocks #8327, #9330, #9531, #9654, #9828

@bridiver
Copy link
Collaborator

closed by brave/muon@cca3034

@jonathansampson
Copy link
Collaborator Author

jonathansampson commented Jul 11, 2017

This appears to have regressed; I'm unable to successfully close a tab in the following build:

Brave: 0.19.0
rev: 2bd7726
Muon: 4.2.6
libchromiumcontent: 59.0.3071.109
V8: 5.9.211.38
Node.js: 7.9.0
Update Channel: dev
os.platform: win32
os.release: 10.0.15063
os.arch: x64

Need to support the following patterns:

  • chrome.tabs.remove(23)
  • chrome.tabs.remove([23, …])
  • chrome.tabs.remove(23, function () {})
  • chrome.tabs.remove([23, …], function () {})

@jonathansampson
Copy link
Collaborator Author

jonathansampson commented Jul 17, 2017

This issue appears to impact LastPass 2FA tabs: #9259

@jonathansampson jonathansampson modified the milestones: 0.17.17 (Release Channel), 0.12.5dev Jul 17, 2017
@bbondy bbondy modified the milestones: 0.18.x (Release Channel), 0.17.17 (Release Channel) Jul 17, 2017
@bridiver
Copy link
Collaborator

I think we stopped handling close in browser-laptop because nothing has changed in muon. The original change to fix the crash no longer makes sense with the changes we made in browser-laptop so I'll commit a workaround to browser-laptop and then update muon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants