Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket and LastPass home page aren't loaded after logging into account #9117

Closed
srirambv opened this issue May 29, 2017 · 8 comments
Closed

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Extension home page doens't load after logging into account

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.16.0
    rev be76cd3
    Muon 3.2.101

  • Steps to reproduce:

    1. Clean install 0.16.0
    2. Enable Pocket/Lastpass, wait for the login page to load in a new tab
    3. Login to account, page keeps showing loading but login is successful on widget
  • Actual result:
    Extension home page doens't load after logging into account

  • Expected result:
    Should load the landing page after successful login

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @kevinlawler @jonathansampson

@srirambv srirambv added this to the 0.16.0 milestone May 29, 2017
@bsclifton bsclifton changed the title Extension home page doens't load after logging into account Extension home page doesn't load after logging into account May 30, 2017
@bsclifton
Copy link
Member

Able to reproduce. I don't see anything logged to stdout, the electron devtools console, or the regular dev console.

Quitting and relaunching seems to fix the problem (although, it's not obviously not a great solution)

@bbondy
Copy link
Member

bbondy commented Jun 8, 2017

It doesn't look like we're getting a fix for this release so moving to 0.17.x

@bbondy bbondy modified the milestones: 0.17.x (Frozen, only critical adds from here), 0.16.x (Frozen, only critical adds from here) Jun 8, 2017
@alexwykoff alexwykoff modified the milestones: 0.18.x (Frozen, only critical adds from here), 0.17.x (Frozen, only critical adds from here) Jun 12, 2017
@bsclifton bsclifton modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
@luixxiul luixxiul changed the title Extension home page doesn't load after logging into account Pocket and LastPass home page aren't loaded after logging into account Jun 24, 2017
@luixxiul luixxiul removed the cr59 label Jun 24, 2017
@alexwykoff
Copy link
Contributor

@srirambv let's look at this again vs 0.18.x and close & move if fixed

@bsclifton
Copy link
Member

@jonathansampson this should work now, right? (is this related to the close API?)
cc: @kevinlawler

@jonathansampson
Copy link
Collaborator

@bsclifton Yes, though the title is a little misleading, I think this is a dupe of the close API.

@jonathansampson
Copy link
Collaborator

Closing as dupe of #4687

@srirambv
Copy link
Collaborator Author

Verifed on 67b911b. Login moves on landing page

@luixxiul luixxiul modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 26, 2017
@luixxiul
Copy link
Contributor

I changed the milestone to 0.18 based on #4687. The fix works nicely :-D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.