Unable to add site to Pocket

[LaurenWags]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Unable to add a site to Pocket. Whenever I click on the pocket icon, I get a login page that spins.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  MacOS (asked @srirambv to confirm on Windows as well)

• Brave Version (revision SHA):
  Name Version
  Brave 0.17.6
  rev 30a3eee
  Muon 4.1.2

• Steps to reproduce:

1. Start with clean install of 0.17.6
2. Enable Pocket in Preferences > Extensions (Pocket Version is 2.1.32)
3. Login to Pocket on tab that opens.
4. You are logged in and navigated to your list.
5. Open a new tab and navigate to a site (I used nytimes.com)
6. Click on a link to open a news article
7. Select the Pocket icon.
8. Pocket login page opens in a new tab and just spins. Site is not added to your list. See screenshot below.

• Actual result:
  Unable to add site to pocket, login page displays and spins

• Expected result:
  Site should be added to pocket, no login page should be displayed.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:
  Pocket and LastPass home page aren't loaded after logging into account #9117 LastPass widget does not open window #9697

cc: @jonathansampson @kevinlawler

[srirambv]

Confirmed on Windows as well.

[bsclifton]

Is this the same issue as #9117? ex: if you exit Brave and relaunch, does the issue still happen? (or is it only on the first load)

[bsclifton]

setting to same milestone as #9117

[LaurenWags]

@bsclifton if I close and relaunch Brave I am still not able to add a site to Pocket (repeating steps 5-8 after Browser is relaunched).

[bsclifton]

@jonathansampson would you be able to check this out? If Pocket isn't working on 0.17.x, should we block the release?

cc: @bbondy @bradleyrichter @alexwykoff

[srirambv]

Works on 0.17.13. Able to add site in pocket when logged in. #9117 still seems to be an issue but pocket functionality seems to be back

[alexwykoff]

Appears to be working, though the first time interaction needs work.

[bbondy]

@jonathansampson is going to verify if this is only for existing tabs and not for new tabs once enabled.

[jonathansampson]

I think this might be a dupe of #4687. I followed the steps, and found the extension_login_success page remaining open. That being said, the site was added to my list.

The login page was only shown for the first engagement of the browserAction icon. All subsequent engagements resulted in no new tab (only the item being added to my list).

[jonathansampson]

This issue is a confirmed dupe of #4687.