Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move getComputedStyle into store #9149

Closed
NejcZdovc opened this issue May 30, 2017 · 1 comment
Closed

Move getComputedStyle into store #9149

NejcZdovc opened this issue May 30, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
QA/no-qa-needed refactoring release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:
Move window.getComputedStyle into app store. We should have const file where we define all variables that are used in getComputedStyle and when app is mounted or resized we will automatically change this values.
@NejcZdovc NejcZdovc added this to the 0.18.x milestone May 30, 2017
@NejcZdovc NejcZdovc self-assigned this May 30, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2017
@NejcZdovc
Saves computed styles in the state
7c933d8 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2017
@NejcZdovc
Saves computed styles in the state
0d4a6ba 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2017
@NejcZdovc
Saves computed styles in the state
573784d 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 31, 2017
@NejcZdovc
Saves computed styles in the state
3e4eabf 
Resolves brave#9149

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue May 31, 2017
Merged
7 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 1, 2017
@NejcZdovc
Saves computed styles in the state
451cf04 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 10, 2017
@NejcZdovc
Saves computed styles in the state
4e595a2 
Resolves brave#9149

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
@NejcZdovc
Saves computed styles in the state
7c8d5ba 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
@NejcZdovc
Saves computed styles in the state
84cfda4 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
@NejcZdovc
Saves computed styles in the state
dae69f6 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
@NejcZdovc
Saves computed styles in the state
a4213bc 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
@NejcZdovc
Saves computed styles in the state
bf7c248 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 15, 2017
@NejcZdovc
Saves computed styles in the state
ca1a1a1 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 15, 2017
@NejcZdovc
Saves computed styles in the state
44c65ae 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 15, 2017
@NejcZdovc
Saves computed styles in the state
c1cfe7e 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 15, 2017
@NejcZdovc
Saves computed styles in the state
cd4775a 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 15, 2017
@NejcZdovc
Saves computed styles in the state
2c1c1be 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 16, 2017
@NejcZdovc
Saves computed styles in the state
e2df69a 
Resolves brave#9149

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jun 16, 2017
@NejcZdovc
Merge pull request #9176 from NejcZdovc/refactor/#9149-computed
f1b2bb8 
Saves computed styles in the state
@luixxiul
Copy link
Contributor

no-qa-needed?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jun 16, 2017
@NejcZdovc NejcZdovc added QA/no-qa-needed and removed needs-info Another team member needs information from the PR/issue opener. labels Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/no-qa-needed refactoring release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
2 participants
@luixxiul @NejcZdovc