Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Allow this time" on NoScript dialog keeps allowing scripts even after reopening the tab #9150

Closed
luixxiul opened this issue May 30, 2017 · 0 comments · Fixed by #9595
Closed

"Allow this time" on NoScript dialog keeps allowing scripts even after reopening the tab #9150

luixxiul opened this issue May 30, 2017 · 0 comments · Fixed by #9595
Assignees
@diracdeltas
Labels
bug feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include security
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 30, 2017 •
edited
Loading

Test plan

#9595 (comment)

Describe the issue you encountered: "Allow this time" on NoScript dialog keeps allowing scripts even after reopening the tab

  • Brave Version (revision SHA): 0.15.310

  • Steps to reproduce:

    1. Clear your brave profle
    2. Open https://github.com
    3. Open Shields panel
    4. Block scripts
    5. Make sure there are 3 scripts blocked
    6. Close the panel
    7. Click noscript icon on the URL bar
    8. Uncheck assets-cdn.github.com (to allow github.com only)
    9. Click Allow this time
    10. Make sure there are 2 scripts blocked
    11. Close the panel
    12. Reopen the tab

  • Actual result: there are 2 scripts blocked

  • Expected result: there should be 3 scripts blocked

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: noscript allowing selective sites once doesn't invalidate the exceptions #9505
@luixxiul luixxiul added this to the 0.18.x milestone Jun 3, 2017
@alexwykoff alexwykoff removed this from the 0.18.x (Frozen, only critical adds from here) milestone Jun 12, 2017
@luixxiul luixxiul mentioned this issue Jun 16, 2017
Closed
@luixxiul luixxiul changed the title "Allow this time" on NoScript dialog keeps blocking scripts after reopening the tab "Allow this time" on NoScript dialog keeps allowing scripts even after reopening the tab Jun 16, 2017
@diracdeltas diracdeltas self-assigned this Jun 20, 2017
@diracdeltas diracdeltas added this to the 0.18.x (Developer Channel) milestone Jun 20, 2017
diracdeltas added a commit that referenced this issue Jun 20, 2017
@diracdeltas
fix noscript allow-once for selective scripts
f5bd582 
fix #9150
@diracdeltas diracdeltas mentioned this issue Jun 20, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Jun 20, 2017
@diracdeltas
fix noscript allow-once for selective scripts
c5d2f7b 
fix #9150

test plan:
1. block scripts globally
2. go to twitter.com
3. click the noscript icon, make sure only 'twitter.com' is checked, click 'allow once'
4. close the tab
5. open twitter.com in a new tab
3. click the noscript icon. 'twitter.com' should appear in the list.
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include security
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

fix noscript allow-once for selective scripts brave/browser-laptop
5 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @LaurenWags