You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Describe the issue you encountered: Remove inlineButton.
I agree with @cezaraugusto that inlineButton is no longer necessary. It had been applied for a cancel button on the advanced settings dialog of Brave Payments. I removed the class with PR #5805, and currently there is no button which includes inlineButton classname.
If you would like to specify display: inline to a button, let's regard the case as an exception and consider to style with inlineStyles on browserButton.js
Extra QA steps:
1.
2.
3.
Any related issues:
The text was updated successfully, but these errors were encountered:
Test plan:
#9230 (comment)
Describe the issue you encountered: Remove inlineButton.
I agree with @cezaraugusto that
inlineButton
is no longer necessary. It had been applied for a cancel button on the advanced settings dialog of Brave Payments. I removed the class with PR #5805, and currently there is no button which includesinlineButton
classname.If you would like to specify
display: inline
to a button, let's regard the case as an exception and consider to style with inlineStyles on browserButton.jsExtra QA steps:
1.
2.
3.
Any related issues:
The text was updated successfully, but these errors were encountered: