Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove inlineButton #9229

Closed
luixxiul opened this issue Jun 3, 2017 · 0 comments
Closed

Remove inlineButton #9229

luixxiul opened this issue Jun 3, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 3, 2017

Test plan:

#9230 (comment)


Describe the issue you encountered: Remove inlineButton.

I agree with @cezaraugusto that inlineButton is no longer necessary. It had been applied for a cancel button on the advanced settings dialog of Brave Payments. I removed the class with PR #5805, and currently there is no button which includes inlineButton classname.

If you would like to specify display: inline to a button, let's regard the case as an exception and consider to style with inlineStyles on browserButton.js

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.