Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove inlineButton #9230

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Remove inlineButton #9230

merged 1 commit into from
Jun 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 3, 2017

Closes #9229

Auditors:

Test Plan:

  1. Open about:styles
  2. Click "button" on TOC
  3. Make sure inlineButton is removed

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Closes #9229

Auditors:

Test Plan:
1. Open about:styles
2. Click "button" on TOC
3. Make sure inlineButton is removed
@luixxiul luixxiul added this to the 0.18.x milestone Jun 3, 2017
@luixxiul luixxiul self-assigned this Jun 3, 2017
@luixxiul luixxiul requested a review from cezaraugusto June 3, 2017 13:27
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks for cleaning up this

@cezaraugusto cezaraugusto merged commit fbe2504 into brave:master Jun 5, 2017
@luixxiul luixxiul mentioned this pull request Jun 5, 2017
@luixxiul luixxiul deleted the remove-inlineButton branch June 6, 2017 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants