Alert disables UI elements and hides URL bar

[luixxiul]

Test plan:

#9656 (comment)

---

Describe the issue you encountered: LastPass security check overwrites "always show URL bar" setting.

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

• Brave Version (revision SHA): 0.15.314

• Steps to reproduce:

  1. Disable "always show URL bar" setting on about:preferences#general
  2. Enable LastPass
  3. Create accounts with two sites sharing login credential (such as www.rakuten.co.jp and www.rakuten-card.co.jp)
  4. Save the credentials
  5. Log in to one of the accounts

• Actual result:
  The URL bar is hidden. Also the lion icon has a strange color.

  

• Expected result:

• Extra QA steps:
  1.
  2.
  3.

• Any related issues:

[cezaraugusto]

this happens for all alert notifications as well, like alert() on a page for example.

opacity in bravery button is intended, see https://github.com/brave/browser-laptop/blob/master/app/renderer/components/navigation/navigator.js#L284.

[cezaraugusto]

given this is not critical I'm pushing back to 0.19.x. Let me know otherwise

[bsclifton]

@luixxiul @cezaraugusto sorry I didn't catch this until now (after seeing #9656)

This behavior is intentional. There are actually tests in place to make sure we disable the lion icon, go into title mode, etc when an alert is shown. The reason being: we don't want folks to navigate in the same webview while the alert is being shown

The Lion is disabled because we don't want the shields menu coming up while the alert is being displayed. You can still switch tabs while the alert is up. After you acknowledge the alert, everything goes back to regular.

[bsclifton]

original notes / discussion in the PR #7107

[luixxiul]

still I believe the strange color should be fixed, which is light yellow.

If it is disabled, it should be grey as we have.

[luixxiul]

I opened an issue for ^: #9696