Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Visited links are not reset when history is cleared #9351

Closed
cndouglas opened this issue Jun 9, 2017 · 1 comment
Closed

Visited links are not reset when history is cleared #9351

cndouglas opened this issue Jun 9, 2017 · 1 comment

Comments

@cndouglas
Copy link

cndouglas commented Jun 9, 2017

Test plan

  1. go to https://www.google.com/#q=test
  2. click on the first result
  3. go to https://www.google.com/#q=test again. the first result should appear as a visited link.
  4. go to History > Clear Browsing Data and clear history.
  5. the visited link should appear as unvisited

  • Did you search for similar issues before submitting this one?
    Yes.

  • Describe the issue you encountered:
    After visiting a link, it changes color. But when the history is cleared (with History > Clear Browsing Data > Browser history), visited links are not reset. Refreshing the page or closing and reopening the page does not make a difference.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS, but likely all platforms.

  • Brave Version (revision SHA):
    0.16.6 (51de9af)

  • Steps to reproduce:

    1. Visit any website with a plain link.
    2. Click the link.
    3. Navigate back.
    4. Notice that the link is now visited (and is colored differently).
    5. Select Menu > History > Clear Browsing Data or Preferences > Security > Clear Browsing Data Now. Select Browsing history and click Clear.
  • Actual result:
    The link remains colored as if it's visited.

  • Expected result:
    The link should be "unvisited" and changed to its original color.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Not sure.

  • Is this an issue in the currently released version?
    Yes, 0.16.6.

  • Can this issue be consistently reproduced?
    Yes.

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    None.

  • Any related issues:
    CSS for visited links ( A:Visited ) does not work #512

@diracdeltas diracdeltas added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017
@diracdeltas diracdeltas self-assigned this Jun 14, 2017
diracdeltas added a commit to brave/muon that referenced this issue Jun 14, 2017
Fix brave/browser-laptop#9351

Test plan:
1. go to https://www.google.com/#q=test
2. click on the first result
3. go to https://www.google.com/#q=test again. the first result should appear as a visited link.
4. go to History > Clear Browsing Data and clear history.
5. the visited link should appear as unvisited
diracdeltas added a commit to brave/muon that referenced this issue Jun 14, 2017
Fix brave/browser-laptop#9351

Test plan:
1. go to https://www.google.com/#q=test
2. click on the first result
3. go to https://www.google.com/#q=test again. the first result should appear as a visited link.
4. go to History > Clear Browsing Data and clear history.
5. the visited link should appear as unvisited
@diracdeltas
Copy link
Member

confirmed that with brave/muon#217, the behavior is the same in Chrome and Brave

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.