Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sync objectsById should be cleared when browser quits #9405

Closed
diracdeltas opened this issue Jun 12, 2017 · 2 comments · Fixed by #9407
Closed

sync objectsById should be cleared when browser quits #9405

diracdeltas opened this issue Jun 12, 2017 · 2 comments · Fixed by #9407
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.x Release

Comments

@diracdeltas
Copy link
Member

since the cache gets rebuilt when sync starts, there is no need to write it to disk

test plan:

  1. start pyramid 0, enable sync
  2. bookmark some sites
  3. close the browser
  4. you should not see 'objectsById' in the session-store-1 file
@diracdeltas diracdeltas added this to the 0.18.x (Frozen, only critical adds from here) milestone Jun 12, 2017
@diracdeltas diracdeltas self-assigned this Jun 12, 2017
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
Fix sync-after-import-bookmark hierarchy
3ea1f8f 
Fix #8892
Fix #9405
Fix #9404
@diracdeltas diracdeltas mentioned this issue Jun 12, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
follow ups to fix for #9308
52bbcaf 
fix #9405
fix #9404
@diracdeltas diracdeltas mentioned this issue Jun 12, 2017
Merged
8 tasks
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

@diracdeltas is this what is expected?

clipboard01

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jul 26, 2017
@diracdeltas
Copy link
Member Author

@luixxiul yup!

@luixxiul luixxiul added QA/checked-Linux and removed needs-info Another team member needs information from the PR/issue opener. labels Jul 26, 2017
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

follow ups to fix for #9308 brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @LaurenWags