This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
appState.sites sort takes a long time (Every navigation +200 ms [w/ 10K bookmarks]) #9427
Comments
ayumi
added a commit
that referenced
this issue
Jun 13, 2017
Because both operations retain sites iteration order. Fix #9427
8 tasks
35 tasks
bridiver
pushed a commit
that referenced
this issue
Jun 14, 2017
Because both operations retain sites iteration order. Fix #9427
bridiver
pushed a commit
that referenced
this issue
Jun 14, 2017
Because both operations retain sites iteration order. Fix #9427
This was referenced Jun 19, 2017
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Sorting sites takes 200 ms (w/ 10K bookmarks) and we do it on every navigation (sitesReducer APP_ADD_SITE).
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Navigation is slow. I noticed the APP_ADD_SITE event took a while to run in reducers.
Platform (Win7, 8, 10? macOS? Linux distro?):
MacOS
Brave Version (revision SHA):
849f5fd
Steps to reproduce:
Actual result:
Sort every time (+200 ms)
Expected result:
Re-sorting should be unnecessary unless site.order has changed.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Import 10K bookmarks
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
Any related issues:
Application slowness (when opening new tabs, loading a website) #8541
The text was updated successfully, but these errors were encountered: