Intermittent Issues with Look Up selection

[jonathansampson]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  From a user on Twitter:

In Brave, when highlighting word, right clicking, & selecting "Look Up", the result is frequently blank or another definition.

This issue was confirmed by both Brendan Eich and Brian Bondy.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS

• Brave Version (revision SHA):
  N/A

• Steps to reproduce:

  1. Highlight a word
  2. Right click, select "Look Up"

• Actual result:
  Results are often blank, or incorrect.

• Expected result:
  Definition for the selected term should be shown.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  N/A

• Is this an issue in the currently released version?
  N/A

• Can this issue be consistently reproduced?
  Yes

• Relevant Source:

contextMenus.js#L966

const showDefinitionMenuItem = (selectionText) => {
  let lookupText = textUtils.ellipse(selectionText, 3)
  return {
    label: locale.translation('lookupSelection').replace(/{{\s*selectedVariable\s*}}/, lookupText),
    click: (item) => {
      webviewActions.showDefinitionForSelection()
    }
  }
}

[cndouglas]

+1 from me.

Related: #8554 (Show definition popup is misaligned).

I started seeing this problem with 0.15.0 (Chromium 58).

[lzmartinico]

It's a problem with electron electron/electron#8905 for my Brave build, I get the same behaviour as described in Javan's last comment. It may be useful until Electron is fixed to call showDefinitionForSelection so as to populate the search bar in the dictionary app?

[cndouglas]

Seems fixed. I cannot reproduce with Brave 0.20.30 on macOS 10.13.x. This may have been fixed with 0.18.x/0.19.x (around the same time as #8554).

[bsclifton]

Closing as this appears fixed for me too 😄

[bsclifton]

There is a similar issue (maybe this was what was reported):
#12695

This issue (linked) has exact steps to repro

[jonathansampson]

Appears to be working for me too.