Show definition popup is misaligned

[cndouglas]

Test plan

1. Ensure Bookmarks Toolbar is hidden
2. Select a word on a webpage.
3. Right-click > Look Up or use the three finger tap gesture (trackpad).
4. Make sure the popup is just below the word that was selected
5. Repeat steps 2 - 4 with Bookmarks Toolbar being visible

Original issue description

• Did you search for similar issues before submitting this one?
  Yes.

• Describe the issue you encountered:
  If you click Look Up or use the three finger gesture to show the dictionary definition of a word, the popup is misaligned.

The location of the popup depends on:

1. The method used to show the definition: Look Up menu item or three finger gesture.
2. Whether the bookmarks toolbar is visible.

This leads me to believe it's a screen coordinate issue introduced with the switch to Chromium 58.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS 10.12.x (macOS only)

• Brave Version (revision SHA):
  0.15.0 (71fb730)

• Steps to reproduce:

  1. Select a word on a webpage.
  2. Right-click > Look Up or use the three finger (trackpad) gesture.

• Actual result:
  The popup is misaligned (see screenshots).

• Expected result:
  The popup should appear below the word.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Probably, but I haven't tested.

• Is this an issue in the currently released version?
  Yes, 0.15.0.

• Can this issue be consistently reproduced?
  Yes.

• Extra QA steps:

  1. Select a word on a webpage.
  2. Right-click > Look Up or use the three finger tap gesture (trackpad).
  3. Make sure the popup is just below the word.

• Screenshot if needed:

With three finger gesture

Without bookmarks toolbar (hidden):

With bookmarks toolbar visible:

• Any related issues:
  None.

[luixxiul]

+1 from #10728

[cndouglas]

Appears to be fixed in Brave 0.21.4 (current dev build).

[luixxiul]

Closing for QA.

[cndouglas]

FYI, I think it was fixed with Chromium 64, so it might be fixed in the 0.19.x hotfix 13 soon to be released.

[bsclifton]

I suspect that the underlying fix for this also caused #12652 (which has now been fixed)

Thanks for finding / closing this, @liunkae 😄 👍

[LaurenWags]

Still doesn't seem quite right:

Additional notes: I had one bookmark on the bookmarks toolbar, but the toolbar was hidden.

[bsclifton]

@LaurenWags I think the issue you found is different- it looks to have unintentionally selected the wrong words? The actual alignment seems to be fine. Seems to be when you click and drag (to create a selection) versus double clicking a word

Closing this issue as the alignment is fixed- would you mind creating a new issue for that? 😄

[LaurenWags]

Opened #12695 for #8554 (comment)