Autofill dropdown is not shown below the input field

[srirambv]

Test plan

1. Have autofill data saved in about:autofill
2. Visit https://www.roboform.com/filling-test-all-fields
3. Click on First name, autofill data is properly shown below the clicked field
4. Try this also with a saved password (with built in password manager). Brave will popup username autofill popup

Description

Autofill dropdown is not shown below the input area

Steps to Reproduce

1. Have autofill data saved in about:autofill
2. Visit https://www.roboform.com/filling-test-all-fields
3. Click on First name, autofill data is not shown below the clicked field

Actual result:
0.19.134 vs 0.19.135

Expected result:
Autofill suggestion should be shown below the clicked input area

Reproduces how often:
100%

Brave Version

about:brave info:

Brave	0.19.135	0.19.134
rev	1f3af75	316cfa5
Muon	4.7.0	4.5.38
libchromiumcontent	64.0.3282.71	63.0.3239.132
V8	6.4.388.12	6.3.292.49
Node.js	7.9.0	7.9.0
Update Channel	Release	Release
OS Platform	Microsoft Windows	Microsoft Windows
OS Release	10.0.16299	10.0.16299
OS Architecture	x64	x64

Reproducible on current live release:
No

Additional Information

cc: @bsclifton @darkdh

[kjozwiak]

This is also affecting where saved passwords are being displayed when clicking on input fields.

Using 0.19.136 1659471 under macOS 10.13.2

[bsclifton]

Here's an example of the coordinates involved...

with Chromium 63

and with Chromium 64 (same code)

With Chromium 64, the targetRect passed in a y value of 219 versus the y of 145 (74 pixels difference) with 63

[bsclifton]

continuing on the above...

With 63 (and existing code), targetRect is added to boundingClientRect (notice the top value of 74) because the targetRect is for inside the webview.

With 64, targetRect is using screen coordinates already (instead of being relative to the webview). Therefore, we don't need to add the window chrome size (boundingClientRect) to it

[bsclifton]

Fixed in 0.19.x with a7c1cbe