Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use Chromium spell checker #9880

Closed
darkdh opened this issue Jul 5, 2017 · 3 comments · Fixed by #9951
Closed

Use Chromium spell checker #9880

darkdh opened this issue Jul 5, 2017 · 3 comments · Fixed by #9951
Assignees
@darkdh
Labels
feature/context-menu perf QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@darkdh
Copy link
Member

darkdh commented Jul 5, 2017 •
edited by bsclifton
Loading

Test plan

See #9951

Original issue description

deprecate electron spell checker
@darkdh darkdh self-assigned this Jul 5, 2017
@bsclifton bsclifton changed the title Using chomium spell checker Use Chromium spell checker Jul 6, 2017
@cndouglas
Copy link

Let's recheck the spellcheck issues after this is implemented.

@Jacalz
Copy link
Contributor

Jacalz commented Jul 7, 2017

Hope that this closes #7967

darkdh added a commit that referenced this issue Jul 11, 2017
@darkdh
Using Chromium's spellchecker
e394659 
fixes #9880

Auditors: @bridiver, @bbondy, @bsclifton
@darkdh darkdh mentioned this issue Jul 11, 2017
Merged
8 tasks
darkdh added a commit that referenced this issue Jul 11, 2017
@darkdh
Using Chromium's spellchecker
309e703 
fixes #9880

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit that referenced this issue Jul 11, 2017
@darkdh
Using Chromium's spellchecker
b642b29 
fixes #9880

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit that referenced this issue Jul 14, 2017
@darkdh
Using Chromium's spellchecker
04b1288 
fixes #9880

Auditors: @bridiver, @bbondy, @bsclifton

Test plan:
a. Suggestions

1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. You can see `bravo`, `brave`, `Brava`
6. Click on `brave`
7. The text should be replaced with `brave` with no redline

b. Learn Spelling
1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. Click `Learn Spelling`
6. `braave` will no longer be redlined
7.  Next time you type `braave`, you will not see redline

c. Forget Learned Spelling
1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. Click `Learn Spelling`
6. `braave` will no longer be redlined
7. Open context menu on `braave`
8. Click `Forget Learned Spelling`
9.  Next time you type `braave`, you will see redline under it

d. Legacy data migration
1. Use older Brave to `Learn Spelling` for `braave` and `Ignore
Spelling` for `braaave`
2. Update to the version with chromium spellchecker
3. There will be no `dictionary` structure in session store
4. You can see those two words will be added to `Custom Dictionary.txt`
under user folder
5. And try to type `braave` and `braaave` in `about:styles`
6. They should be valid words
darkdh added a commit that referenced this issue Jul 14, 2017
@darkdh
Using Chromium's spellchecker
4bcde36 
fixes #9880

Auditors: @bridiver, @bbondy, @bsclifton

Test plan:
a. Suggestions

1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. You can see `bravo`, `brave`, `Brava`
6. Click on `brave`
7. The text should be replaced with `brave` with no redline

b. Learn Spelling
1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. Click `Learn Spelling`
6. `braave` will no longer be redlined
7.  Next time you type `braave`, you will not see redline

c. Forget Learned Spelling
1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. Click `Learn Spelling`
6. `braave` will no longer be redlined
7. Open context menu on `braave`
8. Click `Forget Learned Spelling`
9.  Next time you type `braave`, you will see redline under it

d. Legacy data migration
1. Use older Brave to `Learn Spelling` for `braave` and `Ignore
Spelling` for `braaave`
2. Update to the version with chromium spellchecker
3. There will be no `dictionary` structure in session store
4. You can see those two words will be added to `Custom Dictionary.txt`
under user folder
5. And try to type `braave` and `braaave` in `about:styles`
6. They should be valid words
bsclifton pushed a commit that referenced this issue Jul 14, 2017
@darkdh @bsclifton
Using Chromium's spellchecker
e4aac3b 
fixes #9880

Auditors: @bridiver, @bbondy, @bsclifton

Test plan:
a. Suggestions

1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. You can see `bravo`, `brave`, `Brava`
6. Click on `brave`
7. The text should be replaced with `brave` with no redline

b. Learn Spelling
1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. Click `Learn Spelling`
6. `braave` will no longer be redlined
7.  Next time you type `braave`, you will not see redline

c. Forget Learned Spelling
1. Go to `about:styles`
2. Type `braave` in textbox
3. There should be redline under `braave`
4. Open context menu on `braave`
5. Click `Learn Spelling`
6. `braave` will no longer be redlined
7. Open context menu on `braave`
8. Click `Forget Learned Spelling`
9.  Next time you type `braave`, you will see redline under it

d. Legacy data migration
1. Use older Brave to `Learn Spelling` for `braave` and `Ignore
Spelling` for `braaave`
2. Update to the version with chromium spellchecker
3. There will be no `dictionary` structure in session store
4. You can see those two words will be added to `Custom Dictionary.txt`
under user folder
5. And try to type `braave` and `braaave` in `about:styles`
6. They should be valid words
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Jul 14, 2017
@bsclifton bsclifton mentioned this issue Jul 19, 2017
Closed
@bsclifton bsclifton modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 23, 2017
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
@Jacalz
Copy link
Contributor

Jacalz commented Jul 27, 2017

I don´t seem to be able to forget spelling in ia32 😕

@cndouglas cndouglas mentioned this issue Aug 1, 2017
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/context-menu perf QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

Using Chromium's spellchecker brave/browser-laptop
7 participants
@luixxiul @bsclifton @darkdh @srirambv @cndouglas @Jacalz @LaurenWags