Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sites visited before payment enabling is shown as 0 views #9980

Closed
srirambv opened this issue Jul 12, 2017 · 2 comments
Closed

Sites visited before payment enabling is shown as 0 views #9980

srirambv opened this issue Jul 12, 2017 · 2 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jul 12, 2017

Test plan

See below


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Sites visited before payment enabling is shown as 0 views

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Found on 0.17.16

  • Steps to reproduce:

    1. Clean install 0.17.16
    2. Visit Netflix and view a video
    3. Enable payments
    4. Visit other sites and visit Netflix
    5. Netflix shows as views 0 and % 0
  • Actual result:
    Sites visited before payment enabling is shown as 0 views

  • Expected result:
    Calculation should be done properly

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Could be checked from 0.16.9 but was not able to reproduce it

  • Can this issue be consistently reproduced?
    No

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @cezaraugusto

@srirambv
Copy link
Collaborator Author

Seeing this issue on visiting sites after payment is enabled. This is seen on 0.17.17 RC
image

@cezaraugusto cezaraugusto removed their assignment Aug 16, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 26, 2017
@NejcZdovc NejcZdovc added this to the 0.19.x Release 2 (Beta Channel) milestone Sep 26, 2017
@NejcZdovc
Copy link
Contributor

this was broken with #9952

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.