Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Do not delete exclusion's list website if enabled by publisherToggle #9952

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jul 11, 2017

Fix #9938

This allows websites from exclusion list to be visible if the user decides to. Usually, excluded-list websites aren't included but the user can opt-in by hitting the publisherToggle.

Test plan:

  1. Enable payments;
  2. Go to a verified website;
  3. Website should be visible in payments;
  4. Toggle on/off;
  5. works, site is not excluded;
  6. Go to an unverified website (not in the exclusion list), like wired.com;
  7. Hit the publisherToggle;
  8. Website should be visible in payments;
  9. Toggle on/off;
  10. works, site is not excluded;
    (now the bug that this PR fixes)
  11. Go to an excluded website (google, brave, netflix)
  12. keep navigating in the website up to a point that it should match minimal visibility criteria;
  13. Website should not be visible in payments;
  14. Back to website, hit publisherToggle
  15. Website should be visible in payments;
  16. Toggle on/off;
  17. works, site is not excluded;
  18. Exclude a website by hitting the trash icon inside payments;
  19. Should not be visible;
  20. Go to wheel icon and disable payments for non-verified;
  21. Only verified websites should be visible

@cezaraugusto cezaraugusto added this to the 0.17.15 (Release Channel) milestone Jul 11, 2017
@cezaraugusto cezaraugusto self-assigned this Jul 11, 2017
@mrose17 mrose17 removed their request for review July 11, 2017 03:08
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as described 👍 Code changes look good too- thanks, @cezaraugusto! 😄

@bsclifton bsclifton merged commit fef48f1 into master Jul 11, 2017
@bsclifton bsclifton deleted the ledger-9938 branch July 11, 2017 21:38
bsclifton added a commit that referenced this pull request Jul 11, 2017
Do not delete exclusion's list website if enabled by publisherToggle
bsclifton added a commit that referenced this pull request Jul 11, 2017
Do not delete exclusion's list website if enabled by publisherToggle
bsclifton added a commit that referenced this pull request Jul 11, 2017
Do not delete exclusion's list website if enabled by publisherToggle
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle payment include button causes the site to be removed from the list
2 participants