Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add duckduckgo.com to whitelist for Brave UA #10022

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Add duckduckgo.com to whitelist for Brave UA #10022

merged 1 commit into from
Jul 17, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 17, 2017

Fix #10020

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
    • It's just modifying a data file so I don't think anything is needed. onBeforeSendHeaders could benefit from a test but it's not newly introduced here.
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
See #10020 (comment)

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.17.17 (Release Channel) milestone Jul 17, 2017
@bbondy bbondy self-assigned this Jul 17, 2017
@bbondy bbondy requested a review from bsclifton July 17, 2017 19:35
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 93b105a into master Jul 17, 2017
@bsclifton bsclifton deleted the 10020 branch July 17, 2017 19:46
bsclifton added a commit that referenced this pull request Jul 17, 2017
Add duckduckgo.com to whitelist for Brave UA
bsclifton added a commit that referenced this pull request Jul 17, 2017
Add duckduckgo.com to whitelist for Brave UA
bsclifton added a commit that referenced this pull request Jul 17, 2017
Add duckduckgo.com to whitelist for Brave UA
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants