Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update aphrodite to ^1.2.3 #10061

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Update aphrodite to ^1.2.3 #10061

merged 1 commit into from
Jul 22, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 19, 2017

See https://github.com/Khan/aphrodite/blob/master/CHANGELOG.md for changelog

Closes #10062

Auditors: @bbondy

Test Plan: automated tests should pass

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

See https://github.com/Khan/aphrodite/blob/master/CHANGELOG.md for changelog

Auditors: @bbondy

Test Plan: automated tests should pass
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Jul 19, 2017
@luixxiul luixxiul self-assigned this Jul 19, 2017
@luixxiul luixxiul requested a review from bbondy July 19, 2017 16:41
@bsclifton
Copy link
Member

Great find, @luixxiul! Lots of optimizations 😄

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm playing around with this for a while and couldn't find any issue. Also, they have been focusing on perf improvements in the latest versions so definitely worth including. Thanks!

@cezaraugusto cezaraugusto merged commit fdd4c09 into brave:master Jul 22, 2017
@cezaraugusto cezaraugusto deleted the update-aphrodite branch July 22, 2017 02:59
@bsclifton bsclifton removed this from the 0.21.x milestone Jul 25, 2017
@bsclifton
Copy link
Member

Milestone removed and reverted tag added. See comments here in #10062 (comment)

@luixxiul luixxiul removed the request for review from bbondy July 31, 2017 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants