-
Notifications
You must be signed in to change notification settings - Fork 975
Moves bookmarks manager from js to app #10074
Conversation
3819c64
to
735e61f
Compare
Resolves brave#10074 Auditors: @bsclifton Test Plan: - check if bookmarks manager is displayed correctly
Resolves brave#10075 Auditors: @bsclifton Test Plan: - check if bookmarks manager is displayed correctly
735e61f
to
bc06f35
Compare
@cezaraugusto I am gonna merge this one, because it's a simple split and move. If you find anything that is problematic, please let me know and I will do a follow up. I need this one in the master to continue with my work on #9978 |
well I was reviewing it now, pls ping me before doing that |
@cezaraugusto it was 3am+ in the morning where you are, so I was assuming that you are in the bed already 😃 |
@NejcZdovc Unless test code is updated/added, please avoid adding |
@luixxiul test code for bookmark manager is already there, this PR just moves files into app folder, no logic was changed, no new code was added. |
It is possible for all of us to make a mistake, however tiny it can be, even when moving something to somewhere, and I believe that is partly why we stopped accepting a direct merge to the master branch and started requring a review before merging a PR. IMO manual tests are required on the same reason |
I agree- each pull request needs to do one of the following:
Reviewing this PR, these changes should be covered by automated tests. In this case, we can call out the specific statements to run... For example: |
With this PR I added label
Hope that this make sense and I wanted to save some QA time with it 😃 |
if adding QA/no-qa-needed, at least let's wait a code review is done. Otherwise it would look too hasty, IMHO. Without landing the commit to the master, you could have been able to continue work #9978 by cherry-picking the commit temporarily. |
@luixxiul I already talked with @cezaraugusto about this review and that was completely my mistake, because I though that he was asleep, but he was actually already reviewing it 😃 I see that this is important, so I will leave QA needed there for this type of PR's (moves and tests). IMHO this will just take additional (valuable) time for things that don't needed QA attention from QA team |
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #10075
Auditors: @bsclifton
Test Plan:
Reviewer Checklist:
Tests