Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

WIP: No active tab sometimes happens when dragging off or closing tabs #10095

Closed
wants to merge 1 commit into from

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 23, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.18.x (Beta Channel) milestone Jul 23, 2017
@bbondy bbondy changed the title WIP WIP: No active tab sometimes happens when dragging off or closing tabs Jul 23, 2017
@bbondy bbondy self-assigned this Jul 23, 2017
@codecov-io
Copy link

codecov-io commented Jul 23, 2017

Codecov Report

Merging #10095 into master will decrease coverage by 0.59%.
The diff coverage is 28%.

@@            Coverage Diff            @@
##           master   #10095     +/-   ##
=========================================
- Coverage   52.95%   52.36%   -0.6%     
=========================================
  Files         228      228             
  Lines       20308    20324     +16     
  Branches     3254     3256      +2     
=========================================
- Hits        10754    10642    -112     
- Misses       9554     9682    +128
Flag Coverage Δ
#unittest 52.36% <28%> (-0.6%) ⬇️
Impacted Files Coverage Δ
js/actions/windowActions.js 5.66% <ø> (+0.05%) ⬆️
app/renderer/reducers/frameReducer.js 28.07% <ø> (-0.17%) ⬇️
js/actions/appActions.js 12.68% <ø> (-0.65%) ⬇️
js/constants/appConstants.js 100% <ø> (ø) ⬆️
js/stores/windowStore.js 30.71% <0%> (-0.18%) ⬇️
app/common/state/tabState.js 58.91% <0%> (-14.43%) ⬇️
app/browser/windows.js 17.24% <100%> (ø) ⬆️
app/sessionStore.js 68.2% <100%> (ø) ⬆️
app/browser/tabs.js 24.28% <14.92%> (-0.79%) ⬇️
app/browser/reducers/tabsReducer.js 45.22% <50%> (-4.95%) ⬇️
... and 6 more

@bbondy bbondy force-pushed the tab-index-wip branch 2 times, most recently from ea0dba1 to a43121f Compare July 24, 2017 18:39
@bbondy bbondy modified the milestones: 0.18.x hotfix, 0.18.x (Beta Channel) Jul 25, 2017
@bbondy bbondy force-pushed the tab-index-wip branch 2 times, most recently from 0f709d5 to 841b0b9 Compare July 28, 2017 18:27
@bbondy
Copy link
Member Author

bbondy commented Aug 17, 2017

superseded

@bbondy bbondy closed this Aug 17, 2017
@diracdeltas diracdeltas deleted the tab-index-wip branch January 4, 2018 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants