Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Check tags before using them #10124

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Check tags before using them #10124

merged 1 commit into from
Jul 31, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jul 25, 2017

fix #10122

Auditors: @bsclifton

Test Plan:
See #10122

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@darkdh darkdh self-assigned this Jul 25, 2017
@darkdh darkdh requested a review from bsclifton July 25, 2017 16:20
@darkdh darkdh added this to the 0.20.x (Nightly Channel) milestone Jul 25, 2017
@codecov-io
Copy link

Codecov Report

Merging #10124 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10124      +/-   ##
==========================================
- Coverage   52.69%   52.67%   -0.02%     
==========================================
  Files         227      227              
  Lines       20174    20179       +5     
  Branches     3230     3231       +1     
==========================================
  Hits        10630    10630              
- Misses       9544     9549       +5
Flag Coverage Δ
#unittest 52.67% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
app/browser/windows.js 17.24% <0%> (-0.34%) ⬇️

@darkdh darkdh modified the milestones: 0.19.x (Developer Channel), 0.20.x (Nightly Channel) Jul 26, 2017
@diracdeltas
Copy link
Member

should this go in 0.18.x hotfix? otherwise users with pinned tabs will lose them again when the hotfix comes out

@bsclifton bsclifton modified the milestones: 0.18.x Hotfix, 0.19.x (Developer Channel) Jul 27, 2017
@bsclifton
Copy link
Member

Good call @diracdeltas; I updated this PR and issue to be 0.18 hotfix 😄

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@bsclifton bsclifton merged commit 6c71834 into master Jul 31, 2017
@bsclifton bsclifton deleted the 10122 branch July 31, 2017 07:15
bsclifton added a commit that referenced this pull request Jul 31, 2017
Check tags before using them
bsclifton added a commit that referenced this pull request Jul 31, 2017
Check tags before using them
bsclifton added a commit that referenced this pull request Jul 31, 2017
Check tags before using them
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pinned tab will not display
5 participants