This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Check tags before using them #10124
Merged
Check tags before using them #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #10122 Auditors: @bsclifton Test Plan:
Codecov Report
@@ Coverage Diff @@
## master #10124 +/- ##
==========================================
- Coverage 52.69% 52.67% -0.02%
==========================================
Files 227 227
Lines 20174 20179 +5
Branches 3230 3231 +1
==========================================
Hits 10630 10630
- Misses 9544 9549 +5
|
should this go in 0.18.x hotfix? otherwise users with pinned tabs will lose them again when the hotfix comes out |
Good call @diracdeltas; I updated this PR and issue to be 0.18 hotfix 😄 |
bsclifton
approved these changes
Jul 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
bsclifton
added a commit
that referenced
this pull request
Jul 31, 2017
Check tags before using them
bsclifton
added a commit
that referenced
this pull request
Jul 31, 2017
Check tags before using them
bsclifton
added a commit
that referenced
this pull request
Jul 31, 2017
Check tags before using them
bsclifton
added
QA/test-plan-specified
release-notes/include
feature/pinned-tabs
and removed
QA/test-plan-required
labels
Jul 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10122
Auditors: @bsclifton
Test Plan:
See #10122
Submitter Checklist:
git rebase -i
to squash commits (if needed).Reviewer Checklist:
Tests