Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide bitwarden and pinterest #10345

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Hide bitwarden and pinterest #10345

merged 1 commit into from
Aug 9, 2017

Conversation

bsclifton
Copy link
Member

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
See #10343

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.18.x Hotfix milestone Aug 8, 2017
@bsclifton bsclifton changed the base branch from master to 0.18.x August 8, 2017 23:01
@bsclifton
Copy link
Member Author

bsclifton commented Aug 8, 2017

NOTE: when merging, this needs to be cherry-picked to all branches:

  • 0.18.x
  • 0.19.x
  • 0.20.x
  • master

I can help with this- let me know 😄

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 5fc8b19 into brave:0.18.x Aug 9, 2017
cezaraugusto added a commit that referenced this pull request Aug 9, 2017
cezaraugusto added a commit that referenced this pull request Aug 9, 2017
cezaraugusto added a commit that referenced this pull request Aug 9, 2017
@bsclifton bsclifton deleted the hide-bitwarden-pinterest branch August 9, 2017 04:59
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this pull request Aug 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants