Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

If crashing within first 2min don't lose windows #10381

Merged
merged 1 commit into from
Aug 10, 2017
Merged

If crashing within first 2min don't lose windows #10381

merged 1 commit into from
Aug 10, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 10, 2017

Fix #10349

Auditors: @bsclifton

This happens because a save would happen on init before the initial window state was present

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.18.x Hotfix milestone Aug 10, 2017
@bbondy bbondy self-assigned this Aug 10, 2017
@bbondy bbondy requested a review from bsclifton August 10, 2017 03:38
Fix #10349

Auditors: @bsclifton

This happens because a save would happen on init before the initial window state was present
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #10381 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10381      +/-   ##
==========================================
+ Coverage   53.74%   53.75%   +<.01%     
==========================================
  Files         238      238              
  Lines       21046    21044       -2     
  Branches     3256     3256              
==========================================
+ Hits        11312    11313       +1     
+ Misses       9734     9731       -3
Flag Coverage Δ
#unittest 53.75% <100%> (ø) ⬆️
Impacted Files Coverage Δ
app/sessionStoreShutdown.js 85.8% <100%> (+1.73%) ⬆️

@bbondy bbondy merged commit 2634bbf into master Aug 10, 2017
bbondy added a commit that referenced this pull request Aug 10, 2017
If crashing within first 2min don't lose windows
bbondy added a commit that referenced this pull request Aug 10, 2017
If crashing within first 2min don't lose windows
bbondy added a commit that referenced this pull request Aug 10, 2017
If crashing within first 2min don't lose windows
@bsclifton bsclifton deleted the 10349 branch August 30, 2017 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants