Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Last window closed should be immutable #10437

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Last window closed should be immutable #10437

merged 1 commit into from
Aug 11, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 11, 2017

Auditors: @bsclifton

Fix #10423

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.18.x Hotfix milestone Aug 11, 2017
@bbondy bbondy self-assigned this Aug 11, 2017
@bbondy bbondy requested a review from bsclifton August 11, 2017 19:18
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 👍 I checked for other instances of incorrect session usage and didn't find any. A++, best PR ever! 🥇

@bbondy bbondy merged commit 2e0a37d into master Aug 11, 2017
bbondy added a commit that referenced this pull request Aug 11, 2017
Last window closed should be immutable
bbondy added a commit that referenced this pull request Aug 11, 2017
Last window closed should be immutable
bbondy added a commit that referenced this pull request Aug 11, 2017
Last window closed should be immutable
@codecov-io
Copy link

Codecov Report

Merging #10437 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10437      +/-   ##
==========================================
- Coverage   53.81%    53.8%   -0.01%     
==========================================
  Files         238      238              
  Lines       21051    21051              
  Branches     3258     3258              
==========================================
- Hits        11329    11327       -2     
- Misses       9722     9724       +2
Flag Coverage Δ
#unittest 53.8% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/sessionStoreShutdown.js 85.8% <100%> (ø) ⬆️
app/sessionStore.js 65.11% <0%> (-0.35%) ⬇️

@bbondy
Copy link
Member Author

bbondy commented Aug 11, 2017

Merged 0.18.x, 0.19.x, 0.20.x, master.

@bsclifton bsclifton deleted the 10423 branch August 30, 2017 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants