This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Increase pinned tabs width #10533
Merged
Increase pinned tabs width #10533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
commented
Aug 16, 2017
| @@ -68,12 +71,6 @@ const styles = StyleSheet.create({ | |||
| overflow: 'hidden' | |||
| }, | |||
|
|
|||
| // Add extra space for pages that have no icon | |||
| // such as about:blank and about:newtab | |||
| noFavicon: { | |||
There was a problem hiding this comment.
This is not called anywhere.
luixxiul
commented
Aug 16, 2017
| paddingLeft: globalStyles.spacing.defaultIconPadding, | ||
| paddingRight: globalStyles.spacing.defaultIconPadding | ||
| padding: 0, | ||
| width: `calc(${globalStyles.spacing.tabsToolbarHeight} * 1.1)`, |
There was a problem hiding this comment.
26px * 1.1 is nearly equal to the pinned tab width where the padding is increased from 2px to 4px.
There was a problem hiding this comment.
this seems fragile to me. What if at a given point we decide to update tabs toolbar height?
pinned tabs sizing are also are not used anywhere else so I won't mind having the size explicitly described here.
luixxiul
commented
Aug 16, 2017
| alignSelf: 'center', | ||
| position: 'relative', | ||
| textAlign: 'center', | ||
| justifyContent: 'center', |
There was a problem hiding this comment.
We don't need those.
luixxiul
commented
Aug 16, 2017
| @@ -17,14 +17,13 @@ const globalStyles = require('../../styles/global') | |||
| class TabIcon extends ImmutableComponent { | |||
| render () { | |||
| const styles = StyleSheet.create({ | |||
| icon: { | |||
| tabIcon: { | |||
There was a problem hiding this comment.
Replaced as it is confusing on debugging (we already have icon on styles/tab.js).
luixxiul
commented
Aug 16, 2017
| }, | ||
|
|
||
| active: { | ||
| background: `rgba(255, 255, 255, 1.0)`, | ||
| height: globalStyles.spacing.tabHeight, |
Closes #10368 - Increase pinned tabs width - Remove the hard-coded value from icon_audio Also: - Move styles.audioIcon to tabStyles.icon_audio - Avoid possibility of style inconsistency - Add padding to icon_audio Auditors: @cezaraugusto Test Plan: 1. Open brave.com in a new tab 2. Open github.com in another new tab 3. Pin them 4. Make sure the width of the pinned tabs is as it should be Test Plan 2: 1. Open example.com 2. Pin the tab 3. Make sure the default icon appears at the center of the pinned tab Test Plan 3: 1. Open youtube video 2. Make sure the spacing around the audio icon, favicon and tab's title is equal
Codecov Report
@@ Coverage Diff @@
## master #10533 +/- ##
==========================================
- Coverage 54.32% 54.31% -0.01%
==========================================
Files 245 245
Lines 21159 21156 -3
Branches 3260 3260
==========================================
- Hits 11494 11491 -3
Misses 9665 9665
|
luixxiul
commented
Aug 17, 2017
| @@ -61,17 +61,11 @@ class AudioTabIcon extends React.Component { | |||
|
|
|||
| render () { | |||
| return <TabIcon | |||
| className={css(tabStyles.icon, styles.audioIcon)} | |||
| className={css(tabStyles.icon, tabStyles.icon_audio)} | |||
There was a problem hiding this comment.
Specifying a style in each file will create style inconsistency quite easily.
cezaraugusto
approved these changes
Sep 5, 2017
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10368
Auditors: @cezaraugusto
Test Plan:
Test Plan 2:
Test Plan 3:
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests