Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't prompt for restart when changing Toolbar and UI element scale (… #10578

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Don't prompt for restart when changing Toolbar and UI element scale (… #10578

merged 1 commit into from
Aug 18, 2017

Conversation

bsclifton
Copy link
Member

…since the underlying problem was fixed)

Fixes #10089

Auditors: @luixxiul, @alexwykoff

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

  1. Go to Preferences > Advanced
  2. Under "Toolbar and UI Elements scale", pick a different value from the drop down
  3. you'll be prompted to restart. Ignore this or click "no"
  4. Notice that the top area (where the URL bar is) has changed in size
  5. Notice that you are no longer prompted to restart

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.18.x Hotfix (Release Channel) milestone Aug 18, 2017
@bsclifton bsclifton self-assigned this Aug 18, 2017
@codecov-io
Copy link

Codecov Report

Merging #10578 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10578      +/-   ##
==========================================
- Coverage    54.2%   54.19%   -0.02%     
==========================================
  Files         244      244              
  Lines       21106    21109       +3     
  Branches     3258     3258              
==========================================
- Hits        11441    11440       -1     
- Misses       9665     9669       +4
Flag Coverage Δ
#unittest 54.19% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
js/about/preferences.js 43.38% <ø> (-0.48%) ⬇️

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works great. LGTM.

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 1cf780b into brave:master Aug 18, 2017
@bsclifton bsclifton deleted the remove-prompt-toolbar-ui-scale branch August 30, 2017 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression : Toolbar and UI Elements scale control is not working
4 participants