Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix data URL phishing warning appear on the wrong tab #10760

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Sep 1, 2017

fix #10754

test plan

  1. go to https://jsfiddle.net/y3uw6q1w/
  2. right click the link and open in new tab
  3. no siteInfo popup should appear
  4. switch to the new tab
  5. siteInfo popup should appear
  6. switch to tab 1 and back to tab 2. the siteInfo popup should not appear.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #10754

test plan
1. go to https://jsfiddle.net/y3uw6q1w/
2. right click the link and open in new tab
3. no siteInfo popup should appear
4. switch to the new tab
5. siteInfo popup should appear
6. switch to tab 1 and back to tab 2. the siteInfo popup should not appear.
@diracdeltas diracdeltas added this to the 0.21.x (Nightly Channel) milestone Sep 1, 2017
@diracdeltas diracdeltas self-assigned this Sep 1, 2017
@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #10760 into master will decrease coverage by 0.02%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master   #10760      +/-   ##
==========================================
- Coverage    54.1%   54.08%   -0.03%     
==========================================
  Files         247      247              
  Lines       21519    21529      +10     
  Branches     3332     3335       +3     
==========================================
  Hits        11643    11643              
- Misses       9876     9886      +10
Flag Coverage Δ
#unittest 54.08% <62.5%> (-0.03%) ⬇️
Impacted Files Coverage Δ
app/renderer/reducers/frameReducer.js 25.65% <62.5%> (-1.42%) ⬇️

@diracdeltas diracdeltas requested a review from darkdh September 11, 2017 17:32
@ghost ghost added the sprint/1 label Sep 13, 2017
@@ -183,7 +191,8 @@ const frameReducer = (state, action, immutableAction) => {
})
}
// For potential phishing pages, show a warning
state = state.setIn(['ui', 'siteInfo', 'isVisible'], isPotentialPhishingUrl(action.location))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh
Copy link
Member

darkdh commented Sep 21, 2017

++

@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bypass data: phishing warning by opening a URL in a new tab
6 participants