This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Polish messageBox.js #10835
Merged
Polish messageBox.js #10835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add white-space: pre-wrap to fix #10119 Remove redundant styles Auditors: @cezaraugusto Test Plan: 1. Open https://jsfiddle.net/9o5tmgst/1/ 2. Make sure the lines are wrapped 3. Open https://jsfiddle.net/c5o7arqu/ 3. Make sure everything is properly alinged
luixxiul
added
the
polish
luixxiul
commented
Sep 7, 2017
| @@ -162,34 +161,31 @@ class MessageBox extends React.Component { | |||
| } | |||
|
|
|||
| const styles = StyleSheet.create({ | |||
| dialog: { | |||
| outline: 'none' | |||
There was a problem hiding this comment.
Dialog has this style thanks to 2c3126f#diff-5d3d90fdb0c3efa6acd09057f2d4b101R85 (messageBox is focused by default).
luixxiul
commented
Sep 7, 2017
| outline: 'none' | ||
| }, | ||
| container: { | ||
| outline: 'none', |
There was a problem hiding this comment.
div has outline: none by default.
luixxiul
commented
Sep 7, 2017
| outline: 'none', | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| justifyContent: 'space-between' |
There was a problem hiding this comment.
divs are aligned vertically by default so I think those are not necessary.
Codecov Report
@@ Coverage Diff @@
## master #10835 +/- ##
=======================================
Coverage 54.16% 54.16%
=======================================
Files 247 247
Lines 21548 21548
Branches 3338 3338
=======================================
Hits 11672 11672
Misses 9876 9876
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add white-space: pre-wrap to fix #10119
Remove redundant styles
Auditors: @cezaraugusto
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests