This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix persistent permissions #10958
Merged
Fix persistent permissions #10958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
reviewed
Sep 14, 2017
app/filtering.js
Outdated
| if (response.length === permissionTypes.length) { | ||
| permissionCallbacks[message] = null | ||
| cb(response) | ||
| const repsonseAutoAdded = responseSizeThisIteration !== response.length |
There was a problem hiding this comment.
whoops- s/repsonseAutoAdded/responseAutoAdded
Already covered by this test:
```
1) notificationBar permissions can accept permission request
persistently:
Promise was rejected with the following reason: timeout
```
Fix #10957
bbondy
force-pushed
the
persistent-permission
branch
from
886582c
to
24966d3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge is only for 0.18.x, I'm going to cherry-pick the commit into brianJ's notification branch PR for 0.19.x.
Submitter Checklist:
Fix #10957
Already covered by this failing test:
git rebase -ito squash commits (if needed).Introduced here:
c80b190#diff-8a9bac13ef6264feb2b6da7c18d86b3c
Test Plan:
Reviewer Checklist:
Tests