Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Display brave icon on CheckDefaultBrowserDialog #11044

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Display brave icon on CheckDefaultBrowserDialog #11044

merged 1 commit into from
Sep 20, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 20, 2017

Fixes #11041

Auditors:

Test Plan:

  1. Change the default browser from Brave
  2. Open Brave
  3. Make sure the lion image is displayed on the dialog

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #11041

Auditors:

Test Plan:
1. Change the default browser from Brave
2. Open Brave
3. Make sure the lion image is displayed on the dialog
@luixxiul luixxiul added this to the 0.19.x (Beta Channel) milestone Sep 20, 2017
@luixxiul luixxiul self-assigned this Sep 20, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ nice catch

@cezaraugusto cezaraugusto merged commit 7bfc2e2 into brave:master Sep 20, 2017
cezaraugusto added a commit that referenced this pull request Sep 20, 2017
Display brave icon on CheckDefaultBrowserDialog
cezaraugusto added a commit that referenced this pull request Sep 20, 2017
Display brave icon on CheckDefaultBrowserDialog
@cezaraugusto
Copy link
Contributor

per branch sha:
master 7bfc2e2
0.20.x 011d187
0.19.x 18ecd5a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants