-
Notifications
You must be signed in to change notification settings - Fork 975
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11084 +/- ##
==========================================
+ Coverage 52.6% 53.5% +0.89%
==========================================
Files 268 251 -17
Lines 25237 21885 -3352
Branches 4024 3446 -578
==========================================
- Hits 13277 11709 -1568
+ Misses 11960 10176 -1784
|
@@ -3,7 +3,7 @@ | |||
* You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|||
module.exports = [ | |||
'pre-comit', | |||
'pre-commit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been not sure if this was a typo: #9690 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @NejcZdovc on whether this is a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are sub-dirs of node_modules mostly so yes it's a typo. Thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diracdeltas what do you think about updating the push hook to not run if you have a specific environment variable defined, like NO_PUSH_HOOK_TESTS. If that's defined, we can just noop
@bsclifton that's a reasonable option |
328525b
to
2004350
Compare
@bsclifton done! |
remove unittest from pre-push hook
remove unittest from pre-push hook
remove unittest from pre-push hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ 😄
fix #11081