Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove unittest from pre-push hook #11084

Merged
merged 1 commit into from
Oct 26, 2017
Merged

remove unittest from pre-push hook #11084

merged 1 commit into from
Oct 26, 2017

Conversation

diracdeltas
Copy link
Member

fix #11081

@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #11084 into master will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11084      +/-   ##
==========================================
+ Coverage    52.6%    53.5%   +0.89%     
==========================================
  Files         268      251      -17     
  Lines       25237    21885    -3352     
  Branches     4024     3446     -578     
==========================================
- Hits        13277    11709    -1568     
+ Misses      11960    10176    -1784
Flag Coverage Δ
#unittest 53.5% <ø> (+0.89%) ⬆️
Impacted Files Coverage Δ
app/common/lib/bookmarkUtil.js 58.55% <0%> (-40.77%) ⬇️
app/renderer/components/common/browserButton.js 69.04% <0%> (-26.31%) ⬇️
app/renderer/components/tabs/content/tabIcon.js 45.83% <0%> (-13.26%) ⬇️
app/renderer/components/common/dropdown.js 90.62% <0%> (-9.38%) ⬇️
app/common/state/bookmarkFoldersState.js 67.15% <0%> (-7.66%) ⬇️
app/common/state/bookmarksState.js 80.79% <0%> (-7.04%) ⬇️
app/renderer/reducers/frameReducer.js 50.73% <0%> (-6.28%) ⬇️
...p/renderer/components/tabs/content/closeTabIcon.js 39.06% <0%> (-6.04%) ⬇️
app/common/state/tabUIState.js 25.2% <0%> (-5.49%) ⬇️
app/renderer/reducers/urlBarReducer.js 72.11% <0%> (-4.52%) ⬇️
... and 83 more

@@ -3,7 +3,7 @@
* You can obtain one at http://mozilla.org/MPL/2.0/. */

module.exports = [
'pre-comit',
'pre-commit',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been not sure if this was a typo: #9690 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @NejcZdovc on whether this is a typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are sub-dirs of node_modules mostly so yes it's a typo. Thx.

@cezaraugusto cezaraugusto added needs-info Another team member needs information from the PR/issue opener. dev-setup labels Oct 14, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diracdeltas what do you think about updating the push hook to not run if you have a specific environment variable defined, like NO_PUSH_HOOK_TESTS. If that's defined, we can just noop

@diracdeltas
Copy link
Member Author

@bsclifton that's a reasonable option

@diracdeltas
Copy link
Member Author

@bsclifton done!

@luixxiul luixxiul added this to the Backlog milestone Oct 26, 2017
@bbondy bbondy merged commit 327382d into master Oct 26, 2017
bbondy added a commit that referenced this pull request Oct 26, 2017
remove unittest from pre-push hook
bbondy added a commit that referenced this pull request Oct 26, 2017
remove unittest from pre-push hook
bbondy added a commit that referenced this pull request Oct 26, 2017
remove unittest from pre-push hook
@luixxiul luixxiul modified the milestones: Backlog, 0.19.x Hotfix 3 (Release channel) Oct 28, 2017
@bsclifton bsclifton deleted the tests/no-pre-push branch October 29, 2017 03:54
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev-setup needs-info Another team member needs information from the PR/issue opener.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove unittest from pre-push hook
6 participants