This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
add CanvasRenderingContext2D.prototype.isPointInPath and 4 other meth… #11140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods to fp-blocking
Codecov Report
@@ Coverage Diff @@
## master #11140 +/- ##
==========================================
- Coverage 53.46% 53.41% -0.05%
==========================================
Files 251 251
Lines 21771 21771
Branches 3407 3407
==========================================
- Hits 11639 11630 -9
- Misses 10132 10141 +9
|
diracdeltas
approved these changes
Sep 26, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! the proxy fingerprinting and device enumeration tests are failing but they also fail on master
do we need QA on this? |
luixxiul
added
the
needs-info
Another team member needs information from the PR/issue opener.
label
Sep 26, 2017
unless @snyderp has example sites that use these methods, nope |
bsclifton
added
QA/no-qa-needed
release-notes/include
and removed
needs-info
Another team member needs information from the PR/issue opener.
labels
Sep 26, 2017
i'm going to lift this into 0.19.x hotfix 6 because it's unlikely to break anything and also it solves merge conflict with #11784 |
diracdeltas
modified the milestones:
0.20.x (Beta Channel),
0.19.x Hotfix 6 (Release channel)
Nov 20, 2017
diracdeltas
added a commit
that referenced
this pull request
Nov 20, 2017
add CanvasRenderingContext2D.prototype.isPointInPath and 4 other meth…
0.19.x: 14ef118 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10288
This change would block the following 5 methods (presented below, with brief motivation for each). Numbers for feature use / tracking use are taken from https://www.cs.uic.edu/%7Epsnyder/static/papers/Browser_Feature_Usage_on_the_Modern_Web.pdf
I've added a link to this paper in the FP part of the wiki, along with a description of the SVG related methods. I did not further discuss the canvas and WebGL related methods, since they're already mentioned.
CanvasRenderingContext2D.prototype.isPointInPath
WebGLRenderingContext.prototype.getUniformLocation
andWebGLRenderingContext.prototype.getAttribLocation
SVGPathElement.prototype.getTotalLength
SVGTextContentElement.prototype.getComputedTextLength