Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't remove url suffix when suggestion is selected #11156

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Don't remove url suffix when suggestion is selected #11156

merged 1 commit into from
Sep 26, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 26, 2017

The bug is because of this section in urlBar component's componentDidUpdate:

    } else if (this.props.autocompleteEnabled &&
        this.props.normalizedSuggestion !== prevProps.normalizedSuggestion) {
      this.updateAutocomplete(this.lastVal)
    // This case handles when entering urlmode from tilemode
    }

In this case there is no suggestion because we emptied it out so we shouldn't clear what the user typed in yet.

Fix #11060

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Sep 26, 2017
@bbondy bbondy self-assigned this Sep 26, 2017
@bbondy bbondy requested a review from NejcZdovc September 26, 2017 17:40
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit c9ed9e7 into 0.19.x Sep 26, 2017
@bsclifton bsclifton deleted the 11060 branch September 26, 2017 23:04
bsclifton added a commit that referenced this pull request Sep 26, 2017
Don't remove url suffix when suggestion is selected
@bsclifton
Copy link
Member

0.19.x c9ed9e7
0.20.x ec2f647

@bbondy @NejcZdovc I don't think this should this be merged to master, should it?

bbondy pushed a commit that referenced this pull request Sep 27, 2017
Don't remove url suffix when suggestion is selected
@bbondy
Copy link
Member Author

bbondy commented Sep 27, 2017

It was needed for master as well, merged it here:
9874f96

syuan100 pushed a commit to syuan100/browser-laptop that referenced this pull request Nov 9, 2017
Don't remove url suffix when suggestion is selected
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants