Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Supress node security alert #11187

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Supress node security alert #11187

merged 1 commit into from
Sep 27, 2017

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 27, 2017

Fixes #11168

Auditors: @darkdh, @diracdeltas

Test Plan:

  1. rm -rf node_modules && npm install
  2. npm run check-security

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #11168

Auditors: @darkdh, @diracdeltas

Test Plan:
1. `rm -rf node_modules && npm install`
2. `npm run check-security`
Copy link
Member

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit b625b6d into brave:master Sep 27, 2017
@bsclifton bsclifton deleted the fix-node-alert branch September 27, 2017 22:18
@codecov-io
Copy link

codecov-io commented Sep 27, 2017

Codecov Report

Merging #11187 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11187      +/-   ##
==========================================
- Coverage   54.25%   54.21%   -0.05%     
==========================================
  Files         255      255              
  Lines       22091    22091              
  Branches     3452     3452              
==========================================
- Hits        11986    11977       -9     
- Misses      10105    10114       +9
Flag Coverage Δ
#unittest 54.21% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.49% <0%> (-0.31%) ⬇️

bsclifton added a commit that referenced this pull request Sep 27, 2017
bsclifton added a commit that referenced this pull request Sep 27, 2017
@darkdh
Copy link
Member

darkdh commented Sep 28, 2017

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants