This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Handle ESC via element event handlers #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible for ESC to behave differently depending on whether the find bar is focused.
| @@ -35,6 +35,9 @@ class Main extends ImmutableComponent { | |||
| }) | |||
| } | |||
|
|
|||
| ipc.on(messages.STOP_LOAD, () => { | |||
| electron.remote.getCurrentWebContents().send(messages.SHORTCUT_ACTIVE_FRAME_STOP) | |||
There was a problem hiding this comment.
at some point we should refactor these calls away from remote because I think it does a round trip to parent process then back to child.
|
Looks good, please merge. |
diracdeltas
added a commit
that referenced
this pull request
Dec 30, 2015
Handle ESC via element event handlers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for ESC to behave differently depending on whether the find bar is focused.
auditors: @bbondy