This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Cancel the margin-left of browserButton with groupedItem #11290
Merged
cezaraugusto
merged 1 commit into
brave:master
from
luixxiul:polish-browserButton-groupedItem
Oct 13, 2017
Merged
Cancel the margin-left of browserButton with groupedItem #11290
cezaraugusto
merged 1 commit into
brave:master
from
luixxiul:polish-browserButton-groupedItem
Oct 13, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
misc/button
polish
Nice to have — usually related to front-end/visual tasks.
labels
Oct 5, 2017
Closes #11288 Auditors: Test Plan: 1. Open about:styles 2. Click 'buttons' 3. Make sure the first button in a group does not have the left margin
Codecov Report
@@ Coverage Diff @@
## master #11290 +/- ##
==========================================
- Coverage 52.48% 52.45% -0.04%
==========================================
Files 268 268
Lines 25229 25229
Branches 4026 4026
==========================================
- Hits 13242 13233 -9
- Misses 11987 11996 +9
|
cezaraugusto
approved these changes
Oct 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
As a follow up I'll add a comment to |
@cezaraugusto would you mind adding this to |
cezaraugusto
added a commit
that referenced
this pull request
Oct 13, 2017
Cancel the margin-left of browserButton with groupedItem
0.21.x 9e730c5 |
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11288
Auditors: @cezaraugusto
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests