Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add condition to 'proxy fingerprinting method with WebGL' test #11360

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Add condition to 'proxy fingerprinting method with WebGL' test #11360

merged 1 commit into from
Oct 11, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Oct 8, 2017

It looks Travis requires an additional package to let WebGL run.
Also add 'WebGL' to other tests which require WebGL (for grep).

Follow-up to #10287 (comment)
Related: #3227

var gl = canvas.getContext("webgl")
var format = gl.getShaderPrecisionFormat(gl.VERTEX_SHADER, gl.MEDIUM_FLOAT)

Auditors: @bsclifton

Test Plan:

  1. On macOS, run npm run test -- --grep='proxy fingerprinting method' and make sure the tests pass
  2. On macOS, run npm run test -- --grep='WebGL' and make sure the tests pass
  3. On Travis, make sure that the tests pass
    (On Debian, run npm run test -- --grep='WebGL' and make sure the tests pass)

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

It looks Travis requires an additional package to let WebGL run.
Also add 'WebGL' to other tests which require WebGL.

Related: #3227

Auditors: @bsclifton

Test Plan:
1. On macOS, run `npm run test -- --grep='proxy fingerprinting method'` and make sure the tests pass
1. On macOS, run `npm run test -- --grep='WebGL'` and make sure the tests pass
2. On Travis, make sure that the tests pass
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 8, 2017

https://travis-ci.org/brave/browser-laptop/jobs/284929007#L3275

      ✓ blocks fingerprinting including WebGL (8532ms)
      ✓ blocks fingerprinting including WebGL on compact panel (8691ms)
      ✓ proxy fingerprinting method with WebGL (1476ms)

@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Oct 9, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 9, 2017

CC @snyderp based on 0e40245

@pes10k
Copy link
Contributor

pes10k commented Oct 10, 2017

Thanks for the CC. From looking through the Travis logs it looks like things are good, and that there are still some intermediate fails that are unrelated to the proxy blocking strategy. If I am being dense and missing something though, or if there is something else I can be helpful with, please let me know :)

@luixxiul luixxiul merged commit 9e17cd4 into brave:master Oct 11, 2017
@luixxiul luixxiul deleted the update-proxy-fingerprinting-method branch October 11, 2017 00:35
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@diracdeltas
Copy link
Member

lifting into 0.19.x for #11784

@diracdeltas diracdeltas modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 6 (Release channel) Nov 21, 2017
diracdeltas pushed a commit that referenced this pull request Nov 21, 2017
…ethod

Add condition to 'proxy fingerprinting method with WebGL' test
@diracdeltas
Copy link
Member

0.19.x: 81d7207

@luixxiul luixxiul removed the request for review from bsclifton November 21, 2017 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants