Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix "Warning: validateDOMNesting(...)" error #11524

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Fix "Warning: validateDOMNesting(...)" error #11524

merged 1 commit into from
Oct 16, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Oct 14, 2017

Fixes #11523

Follow-up to #11395

Auditors:

Test Plan:

  1. Open about:preferences#payments

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #11523

Auditors:

Test Plan:
1. Open about:preferences#payments
@codecov-io
Copy link

codecov-io commented Oct 14, 2017

Codecov Report

Merging #11524 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #11524   +/-   ##
=======================================
  Coverage   52.66%   52.66%           
=======================================
  Files         268      268           
  Lines       25218    25218           
  Branches     4022     4022           
=======================================
  Hits        13280    13280           
  Misses      11938    11938
Flag Coverage Δ
#unittest 52.66% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...r/components/preferences/payment/enabledContent.js 91.24% <100%> (ø) ⬆️

@bbondy bbondy merged commit 15303a9 into brave:master Oct 16, 2017
bbondy added a commit that referenced this pull request Oct 16, 2017
Fix "Warning: validateDOMNesting(...)" error
bbondy added a commit that referenced this pull request Oct 16, 2017
Fix "Warning: validateDOMNesting(...)" error
bbondy added a commit that referenced this pull request Oct 16, 2017
Fix "Warning: validateDOMNesting(...)" error
@luixxiul luixxiul deleted the fix-warning-validateDOMNesting branch October 16, 2017 14:49
@luixxiul
Copy link
Contributor Author

master: 15303a9
0.21.x: 63de33f
0.20.x: 046b55c
0.19.x: 49731b5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants