Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

enabling MetaMask via notification when visiting DApp website #11534

Merged
merged 4 commits into from
Oct 15, 2017
Merged

enabling MetaMask via notification when visiting DApp website #11534

merged 4 commits into from
Oct 15, 2017

Conversation

kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Oct 14, 2017 •
edited
Loading

Fixed #11532

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Case 1:

  • ensure MetaMask is disabled via about:preferences#extensions
  • visit https://ethwaterloo.herokuapp.com/
  • ensure that you receive a "This page contains a Dapp, would you like to enable the MetaMask extension?" notification
  • click on "Install MetaMask"
  • ensure that MetaMask is installed (verify via about:preferences#extensions)
  • click on the "MetaMask" icon that appears next to the "Brave" shield icon
  • accept the terms and quickly create a new account
  • click on "I've copied it somewhere safe" under "Vault Created"
  • select the "Ropsten Test Net" from the MetaMask dropdown menu
  • under https://ethwaterloo.herokuapp.com/, refresh the page and select "Go" and ensure the app loads a blockchain map

Case 2:

  • ensure MetaMask is disabled via about:preferences#extensions
  • visit https://ethwaterloo.herokuapp.com/
  • ensure that you receive a "This page contains a Dapp, would you like to enable the MetaMask extension?" notification
  • click on "No Thanks" and ensure "Remember this decision" is selected
  • refresh the website and ensure that the notification isn't being displayed anymore
  • visit https://tokenfactory.surge.sh and ensure that the notification isn't appearing

Case 3:

Case 4:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@kevinlawler @kjozwiak
add metamask to available extensions
7b045c7 
#8671

already added to vault manifest & live on server
brave/vault-updater#43

Auditors:
@bridriver @bsclifton @jonathansampson
@kjozwiak kjozwiak self-assigned this Oct 14, 2017
@kjozwiak kjozwiak requested a review from bbondy October 14, 2017 21:38
bbondy
bbondy approved these changes Oct 15, 2017
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with all this @kjozwiak !
Way 2 go

@bbondy bbondy merged commit 5b4382f into 0.19.x Oct 15, 2017
bbondy added a commit that referenced this pull request Oct 15, 2017
@bbondy
Merge pull request #11534 from brave/ETHWaterloo
6af62cb 
enabling MetaMask via notification when visiting DApp website
bbondy added a commit that referenced this pull request Oct 15, 2017
@bbondy
Merge pull request #11534 from brave/ETHWaterloo
def7455 
enabling MetaMask via notification when visiting DApp website
@bbondy
Copy link
Member

bbondy commented Oct 15, 2017 •
edited
Loading

0.19.x: 5b4382f

0.20.x: 6af62cb

0.21.x: def7455

master: 093c5d3

bbondy added a commit that referenced this pull request Oct 15, 2017
@bbondy
Merge pull request #11534 from brave/ETHWaterloo
093c5d3 
enabling MetaMask via notification when visiting DApp website
@bbondy
Copy link
Member

bbondy commented Oct 15, 2017

metamask

@bbondy
Copy link
Member

bbondy commented Oct 15, 2017 •
edited
Loading

GIF thanks to @kjozwiak

@darkdh darkdh mentioned this pull request Oct 15, 2017
Closed
@jonathansampson jonathansampson mentioned this pull request Oct 16, 2017
Closed
13 tasks
syuan100 pushed a commit to syuan100/browser-laptop that referenced this pull request Nov 9, 2017
@bbondy @syuan100
Merge pull request brave#11534 from brave/ETHWaterloo
eee24d8 
enabling MetaMask via notification when visiting DApp website
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@kjozwiak kjozwiak

Labels
feature/extensions
Projects
None yet
Milestone
0.19.x Hotfix 1 (Release channel)
Development

Successfully merging this pull request may close these issues.
4 participants
@kjozwiak @bbondy @kevinlawler @bsclifton