Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix buttons wrap on about:preferences#payments (l10n) #11579

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Fix buttons wrap on about:preferences#payments (l10n) #11579

merged 1 commit into from
Oct 28, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Oct 17, 2017

Closes #11580

This is required for 0.19.x and 0.20.x only, like #11368

For 0.21.x and master a manual fix will be was applied to #10913

screenshot 2017-10-18 1 51 23

The switch label alignment has been addressed with another PR. On master it looks good.

screenshot 2017-10-18 2 02 05

Auditors:

Test Plan:

  1. Change the lang setting to German (DE)
  2. Restart the browser
  3. Open about:preferences#payments
  4. Make sure the buttons on the title row do not wrap

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Auditors:

Test Plan:
1. Change the lang setting to German (DE)
2. Restart the browser
3. Open about:preferences#payments
4. Make sure the buttons on the title row do not wrap
@luixxiul luixxiul self-assigned this Oct 17, 2017
@luixxiul luixxiul requested a review from cezaraugusto October 17, 2017 16:47
@ghost ghost modified the milestones: 0.19.x Hotfix 2 (Release channel), 0.22.x (Nightly Channel) Oct 17, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 17, 2017

@zentagonist if this will not be included to 0.19.x, please close this PR. That has been manually applied to #11368 for 0.21.x. thanks!

@luixxiul luixxiul removed this from the 0.22.x (Nightly Channel) milestone Oct 17, 2017
@luixxiul luixxiul removed the request for review from cezaraugusto October 17, 2017 17:17
@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Oct 17, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 4ae77c6 into brave:0.19.x Oct 28, 2017
@cezaraugusto cezaraugusto deleted the 0.19.x branch October 28, 2017 06:26
cezaraugusto added a commit that referenced this pull request Oct 28, 2017
Fix buttons wrap on about:preferences#payments (l10n)
@cezaraugusto
Copy link
Contributor

0.19.x 4ae77c6
0.20.x 2a26e2c

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Oct 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants