This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fix action buttons placement on torrentViewer #11801
Merged
cezaraugusto
merged 1 commit into
brave:master
from
luixxiul:fix-regression-torrentViewer
Nov 14, 2017
Merged
Fix action buttons placement on torrentViewer #11801
cezaraugusto
merged 1 commit into
brave:master
from
luixxiul:fix-regression-torrentViewer
Nov 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11800 Auditors: Test Plan: 1. Open https://webtorrent.io/torrents/big-buck-bunny.torrent 2. Make sure the action buttons are aligned horizontally with the title
Codecov Report
@@ Coverage Diff @@
## master #11801 +/- ##
==========================================
- Coverage 52.76% 52.72% -0.04%
==========================================
Files 271 271
Lines 25713 25713
Branches 4104 4104
==========================================
- Hits 13567 13558 -9
- Misses 12146 12155 +9
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #11801 +/- ##
==========================================
- Coverage 52.76% 52.72% -0.04%
==========================================
Files 271 271
Lines 25713 25713
Branches 4104 4104
==========================================
- Hits 13567 13558 -9
- Misses 12146 12155 +9
|
cezaraugusto
approved these changes
Nov 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
cezaraugusto
added a commit
that referenced
this pull request
Nov 14, 2017
Fix action buttons placement on torrentViewer
cezaraugusto
added a commit
that referenced
this pull request
Nov 14, 2017
Fix action buttons placement on torrentViewer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11800
Fixes this:
Auditors:
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests