Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix action buttons placement on torrentViewer #11801

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Fix action buttons placement on torrentViewer #11801

merged 1 commit into from
Nov 14, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Nov 6, 2017

Fixes #11800

Fixes this:
screenshot 2017-11-06 17 46 49

Auditors:

Test Plan:

  1. Open https://webtorrent.io/torrents/big-buck-bunny.torrent
  2. Make sure the action buttons are aligned horizontally with the title

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #11800

Auditors:

Test Plan:
1. Open https://webtorrent.io/torrents/big-buck-bunny.torrent
2. Make sure the action buttons are aligned horizontally with the title
@luixxiul luixxiul added the 0.20.x issue first seen in 0.20.x label Nov 6, 2017
@luixxiul luixxiul self-assigned this Nov 6, 2017
@codecov-io
Copy link

Codecov Report

Merging #11801 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11801      +/-   ##
==========================================
- Coverage   52.76%   52.72%   -0.04%     
==========================================
  Files         271      271              
  Lines       25713    25713              
  Branches     4104     4104              
==========================================
- Hits        13567    13558       -9     
- Misses      12146    12155       +9
Flag Coverage Δ
#unittest 52.72% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 26.71% <0%> (-0.3%) ⬇️

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #11801 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11801      +/-   ##
==========================================
- Coverage   52.76%   52.72%   -0.04%     
==========================================
  Files         271      271              
  Lines       25713    25713              
  Branches     4104     4104              
==========================================
- Hits        13567    13558       -9     
- Misses      12146    12155       +9
Flag Coverage Δ
#unittest 52.72% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 26.71% <0%> (-0.3%) ⬇️

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit ed9cb40 into brave:master Nov 14, 2017
cezaraugusto added a commit that referenced this pull request Nov 14, 2017
Fix action buttons placement on torrentViewer
cezaraugusto added a commit that referenced this pull request Nov 14, 2017
Fix action buttons placement on torrentViewer
@cezaraugusto
Copy link
Contributor

master ed9cb40
0.21.x b4b2268
0.20.x f52dfcb

@luixxiul luixxiul deleted the fix-regression-torrentViewer branch November 14, 2017 04:51
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.20.x issue first seen in 0.20.x QA/test-plan-specified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants